From patchwork Fri Feb 19 20:17:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jay Vosburgh X-Patchwork-Id: 585408 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id D6829140909; Sat, 20 Feb 2016 07:17:39 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1aWrUc-0006Ii-Sz; Fri, 19 Feb 2016 20:17:34 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1aWrUY-0006IX-IV for kernel-team@lists.ubuntu.com; Fri, 19 Feb 2016 20:17:30 +0000 Received: from c-67-183-59-65.hsd1.wa.comcast.net ([67.183.59.65] helo=famine.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1aWrUY-0001Mk-6V; Fri, 19 Feb 2016 20:17:30 +0000 Received: by famine.localdomain (Postfix, from userid 1000) id C94BD654C7; Fri, 19 Feb 2016 12:17:28 -0800 (PST) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id C33FAA176F; Fri, 19 Feb 2016 12:17:28 -0800 (PST) From: Jay Vosburgh To: Stefan Bader Subject: Re: ACK/cmnt: [SRU][Trusty][PATCH v2 0/4] bridge: Provide IPv6 refragmentation for bridge conntrack In-reply-to: <56C70C40.1030700@canonical.com> References: <1455669693-19975-1-git-send-email-jay.vosburgh@canonical.com> <56C70C40.1030700@canonical.com> Comments: In-reply-to Stefan Bader message dated "Fri, 19 Feb 2016 13:36:16 +0100." X-Mailer: MH-E 8.5+bzr; nmh 1.5; GNU Emacs 25.0.50 Date: Fri, 19 Feb 2016 12:17:28 -0800 Message-ID: <1412.1455913048@famine> Cc: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com Stefan Bader wrote: >On 17.02.2016 01:41, Jay Vosburgh wrote: >> BugLink: https://bugs.launchpad.net/nova/+bug/1463911 >> >> This is a respin of >> >> https://lists.ubuntu.com/archives/kernel-team/2015-November/065772.html >> https://lists.ubuntu.com/archives/kernel-team/2015-November/065773.html >> https://lists.ubuntu.com/archives/kernel-team/2015-November/065774.html >> >> to break out the consolidated patches into their individual parts. >> >> This patch series provides the ability to re-fragment IPv6 >> datagrams being forwarded by the bridge when conntrack is enabled. >> Conntrack will defragment any datagrams it processes, and presently the >> bridge cannot refragment them on egress (resulting in a drop of affected >> datagrams). >> >> Patches tested according to the recipe provided in patch 3 of the >> series. > >ACK more based on testing results. Especially #3 is hard to verify without being >accustomed to the network code. > >Minor thought on #1: The commit messages talks about renaming a data structure >which was not actually done. Not sure there is already an established method >here but maybe quick note under the backported ... That comment in the commit log refers to the following change in the upstream patch: I left that particular change out because, on the kernels at issue here (3.13, 3.16 and 3.19), the assertion in the commit log that the "only user left is neigh resolution" is not true. Including this change would require a cascade of other changes (because the extant usage exceeds the new neigh_header[8] capacity). That said, I should have explained it better somewhere; I can respin the patches with higher verbosity in the commit log if that would be preferred. -J --- -Jay Vosburgh, jay.vosburgh@canonical.com diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 36f3f43c0117..f66a089afc41 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -169,7 +169,7 @@ struct nf_bridge_info { unsigned int mask; struct net_device *physindev; struct net_device *physoutdev; - unsigned long data[32 / sizeof(unsigned long)]; + char neigh_header[8]; }; #endif