Patchwork [fortran] output of Makefile dependencies

login
register
mail settings
Submitter Gerald Pfeifer
Date July 10, 2010, 11:50 p.m.
Message ID <alpine.LNX.2.00.1007110147270.5661@acrux.dbai.tuwien.ac.at>
Download mbox | patch
Permalink /patch/58501/
State New
Headers show

Comments

Gerald Pfeifer - July 10, 2010, 11:50 p.m.
Tobias,

On Sun, 27 Jun 2010, Tobias Burnus wrote:
> Please have a look at the attached diff. Do you have any suggestions or 
> comments?

indeed I have a few suggestions, and I went ahead and create a patch
around them.

What do you think?

Gerald
Tobias Burnus - July 12, 2010, 7:24 a.m.
Gerald,

On 07/11/2010 01:50 AM, Gerald Pfeifer wrote:
> indeed I have a few suggestions, and I went ahead and create a patch
> around them.
>
> What do you think?
>   

> -	<li>Minor changes: obsolesce diagnostics for <code>ENTRY</code> with
> -	<code>-std=f2008</code>is obsolescent, a line is permitted to start
>
> +	<li>Minor changes: diagnostics for <code>ENTRY</code> with
> +	<code>-std=f2008</code> is obsolete;

My wording was already highly misleading (not to say wrong), yours
completes this ;-) What I meant was the following diagnostic was
_added_: "Warning: Fortran 2008 obsolescent feature: ENTRY statement at
(1)" (i.e. this warning is only printed for -std=f2008; the first
version of the Fortran standard where ENTRY was declared as obsolescent.)

Thus:

+	<li>Minor changes: obsolesce diagnostics for <code>ENTRY</code> with
+	<code>-std=f2008</code> was added;

or something like that. (Thanks also for spotting the missing " ".)

Otherwise, the patch is OK.

Thanks,

Tobias
Tobias Burnus - July 12, 2010, 8:27 a.m.
On 07/12/2010 09:24 AM, Tobias Burnus wrote:
> Gerald,
>
> On 07/11/2010 01:50 AM, Gerald Pfeifer wrote:
>   
>> indeed I have a few suggestions, and I went ahead and create a patch
>> around them.
>>
>> What do you think?
>>     

Unrelated to that patch, but can you add under "Fortran 2008" the item:

  Support for the STORAGE_SIZE intrinsic inquiry function.

Tobias

Patch

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.6/changes.html,v
retrieving revision 1.27
diff -u -r1.27 changes.html
--- changes.html	10 Jul 2010 20:16:08 -0000	1.27
+++ changes.html	10 Jul 2010 23:49:00 -0000
@@ -143,10 +143,10 @@ 
     <li>Much improved compile time for large array constructors.</li>
     <li>Improved diagnostics, especially with
       <code>-fwhole-file</code>.</li>
-    <li>Support the generation of makefile dependencies via the <a
+    <li>Support the generation of Makefile dependencies via the <a
     href="http://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html">
-    <code>-M</code>...</a> flags of GCC; you might need to specifiy
-    additionally the <code>-cpp</code> option. The dependencies take
+    <code>-M</code>...</a> flags of GCC; you may need to specify the
+    <code>-cpp</code> option in addition. The dependencies take
     modules, Fortran's <code>include</code>, and CPP's <code>#include</code>
     into account. Note: Using <code>-M</code> for the module path is no
     longer supported, use <code>-J</code> instead.</li>
@@ -170,13 +170,13 @@ 
 	statements now support all constant expressions.</li>
 	<li>Support for the <code>CONTIGUOUS</code> attribute.</li>
 	<li>Support for <code>ALLOCATE</code> with <code>MOLD</code>.</li>
-	<li>Minor changes: obsolesce diagnostics for <code>ENTRY</code> with
-	<code>-std=f2008</code>is obsolescent, a line is permitted to start
-	with a semicolon, for internal and module procedures <code>END</code>
-	can be used besides <code>END SUBROUTINE</code> and <code>END
-	FUNCTION</code>, <code>SELECTED_REAL_KIND</code> now also takes a
-	<code>RADIX</code> argument, intrinsic types are supported for
-	<code>TYPE(<i>intrinsic-type-spec</i>)</code>, multiple type-bound
+	<li>Minor changes: diagnostics for <code>ENTRY</code> with
+	<code>-std=f2008</code> is obsolete; a line may start
+	with a semicolon; for internal and module procedures <code>END</code>
+	can be used instead of  <code>END SUBROUTINE</code> and <code>END
+	FUNCTION</code>; <code>SELECTED_REAL_KIND</code> now also takes a
+	<code>RADIX</code> argument; intrinsic types are supported for
+	<code>TYPE(<i>intrinsic-type-spec</i>)</code>; multiple type-bound
 	procedures can be declared in a single <code>PROCEDURE</code>
 	statement.</li>
       </ul>