| Message ID | 1455807273-133516-1-git-send-email-mika.westerberg@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote: > Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add > DNV PCI ID to the list of supported devices. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Wolfram, Please do not yet apply this patch. It seems to have same PCI ID that Alexandra (Cc'd) added to i2c-i801.c. Alexandra, are you sure that the PCI ID you added for DNV is actually compatible with i2c-i801.c? > --- > drivers/i2c/busses/i2c-ismt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c > index 7ba795b24e75..24c48e899a22 100644 > --- a/drivers/i2c/busses/i2c-ismt.c > +++ b/drivers/i2c/busses/i2c-ismt.c > @@ -76,6 +76,7 @@ > #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59 > #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a > #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15 > +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac > > #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */ > #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */ > @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) }, > { 0, } > }; > > -- > 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mika, > -----Original Message----- > From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com] > Sent: Friday, February 19, 2016 12:39 AM > To: Wolfram Sang <wsa@the-dreams.de> > Cc: Heasley, Seth <seth.heasley@intel.com>; Neil Horman > <nhorman@tuxdriver.com>; linux-i2c@vger.kernel.org; Yates, Alexandra > <alexandra.yates@intel.com> > Subject: Re: [PATCH] i2c: ismt: Add Intel DNV PCI ID > > On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote: > > Intel DNV has the same iSMT SMBus host controller than Intel Avoton. > > Add DNV PCI ID to the list of supported devices. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Wolfram, > > Please do not yet apply this patch. It seems to have same PCI ID that > Alexandra (Cc'd) added to i2c-i801.c. > > Alexandra, are you sure that the PCI ID you added for DNV is actually > compatible with i2c-i801.c? > I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows: Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host In the same document there is a list of PCI IDs. > > --- > > drivers/i2c/busses/i2c-ismt.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-ismt.c > > b/drivers/i2c/busses/i2c-ismt.c index 7ba795b24e75..24c48e899a22 > > 100644 > > --- a/drivers/i2c/busses/i2c-ismt.c > > +++ b/drivers/i2c/busses/i2c-ismt.c > > @@ -76,6 +76,7 @@ > > #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59 > > #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a > > #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15 > > +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac > > > > #define ISMT_DESC_ENTRIES 2 /* number of descriptor > entries */ > > #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to > attempt */ > > @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, > PCI_DEVICE_ID_INTEL_S1200_SMT0) }, > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, > PCI_DEVICE_ID_INTEL_S1200_SMT1) }, > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, > PCI_DEVICE_ID_INTEL_AVOTON_SMT) }, > > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, > PCI_DEVICE_ID_INTEL_DNV_SMT) }, > > { 0, } > > }; > > > > -- > > 2.7.0 Thank you, Alexandra. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 19, 2016 at 10:39:17AM +0200, Mika Westerberg wrote: > On Thu, Feb 18, 2016 at 04:54:33PM +0200, Mika Westerberg wrote: > > Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add > > DNV PCI ID to the list of supported devices. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Wolfram, > > Please do not yet apply this patch. It seems to have same PCI ID that > Alexandra (Cc'd) added to i2c-i801.c. > > Alexandra, are you sure that the PCI ID you added for DNV is actually > compatible with i2c-i801.c? OK, I also dropped Alexandra's patch until this is cleared. Thanks for the heads up.
Mika, > I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows: > Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host > > In the same document there is a list of PCI IDs. Did this comment help? Thanks, Wolfram
On Thu, Mar 03, 2016 at 10:15:38PM +0100, Wolfram Sang wrote: > Mika, > > > I go this device ID from the External Design Specification (EDS) document for DNV. The EDS lists this as the SMBus Controller as follows: > > Bus: 0 Device:18 Function:0 Device ID: 0x19AC Description: SMBus Controller - Host > > > > In the same document there is a list of PCI IDs. > > Did this comment help? Not really. We are figuring out which one it is and will send a new patch as soon as we know better :) -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c index 7ba795b24e75..24c48e899a22 100644 --- a/drivers/i2c/busses/i2c-ismt.c +++ b/drivers/i2c/busses/i2c-ismt.c @@ -76,6 +76,7 @@ #define PCI_DEVICE_ID_INTEL_S1200_SMT0 0x0c59 #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15 +#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */ #define ISMT_MAX_RETRIES 3 /* number of SMBus retries to attempt */ @@ -181,6 +182,7 @@ static const struct pci_device_id ismt_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT0) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) }, + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) }, { 0, } };
Intel DNV has the same iSMT SMBus host controller than Intel Avoton. Add DNV PCI ID to the list of supported devices. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/i2c/busses/i2c-ismt.c | 2 ++ 1 file changed, 2 insertions(+)