Patchwork Block migration fail, ignore error from bdrv_getlength

login
register
mail settings
Submitter Shahar Havivi
Date July 10, 2010, 11:16 a.m.
Message ID <20100710111559.GA4129@redhat.com>
Download mbox | patch
Permalink /patch/58472/
State New
Headers show

Comments

Shahar Havivi - July 10, 2010, 11:16 a.m.
When there is no block driver associate with BlockDriverState bdrv_getlength
returns -ENOMEDIUM that cause block migration to fail.

Signed-off-by: Shahar Havivi <shaharh@redhat.com>
---
 block-migration.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
shavivi@redhat.com - July 10, 2010, 12:19 p.m.
It need to be sectors <= 0,
Will send v2

On Jul 10, 2010, at 14:15, Shahar Havivi <shaharh@redhat.com> wrote:

> When there is no block driver associate with BlockDriverState bdrv_getlength
> returns -ENOMEDIUM that cause block migration to fail.
> 
> Signed-off-by: Shahar Havivi <shaharh@redhat.com>
> ---
> block-migration.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/block-migration.c b/block-migration.c
> index 7db6f02..3d78748 100644
> --- a/block-migration.c
> +++ b/block-migration.c
> @@ -238,7 +238,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs)
> 
>     if (!bdrv_is_read_only(bs)) {
>         sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
> -        if (sectors == 0) {
> +        if (sectors < 0) {
>             return;
>         }
> 
> -- 
> 1.7.1.1
>

Patch

diff --git a/block-migration.c b/block-migration.c
index 7db6f02..3d78748 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -238,7 +238,7 @@  static void init_blk_migration_it(void *opaque, BlockDriverState *bs)
 
     if (!bdrv_is_read_only(bs)) {
         sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
-        if (sectors == 0) {
+        if (sectors < 0) {
             return;
         }