ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node
diff mbox

Message ID 1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com
State New
Headers show

Commit Message

Romain Izard Feb. 18, 2016, 10:21 a.m. UTC
All pinctrl nodes for the Atmel pinctrl controller need to have their
bias configuration explicitly defined. Otherwise, the pinctrl mapping
is not valid.

It works for now as the pinctrl driver proceeds even with invalid
mappings, but this can become an issue, if the pinctrl driver starts
to require valid mappings. Additionally, the pin is not protected from
being remapped later by an other driver.

There is an external 1kΩ pull-up to 3.3V, so no bias is required on
the Ethernet PHY's interrupt line.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
 arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

ludovic.desroches@atmel.com Feb. 19, 2016, 1:19 p.m. UTC | #1
On Thu, Feb 18, 2016 at 11:21:06AM +0100, Romain Izard wrote:
> All pinctrl nodes for the Atmel pinctrl controller need to have their
> bias configuration explicitly defined. Otherwise, the pinctrl mapping
> is not valid.
> 
> It works for now as the pinctrl driver proceeds even with invalid
> mappings, but this can become an issue, if the pinctrl driver starts
> to require valid mappings. Additionally, the pin is not protected from
> being remapped later by an other driver.
> 
> There is an external 1kΩ pull-up to 3.3V, so no bias is required on
> the Ethernet PHY's interrupt line.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>

Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Thanks

> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index e683856c507c..75341eec2dfd 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -308,6 +308,7 @@
>  
>  				pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					pinmux = <PIN_PC9__GPIO>;
> +					bias-disable;
>  				};
>  
>  				pinctrl_pdmic_default: pdmic_default {
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nicolas Ferre March 1, 2016, 9:48 a.m. UTC | #2
Le 18/02/2016 11:21, Romain Izard a écrit :
> All pinctrl nodes for the Atmel pinctrl controller need to have their
> bias configuration explicitly defined. Otherwise, the pinctrl mapping
> is not valid.
> 
> It works for now as the pinctrl driver proceeds even with invalid
> mappings, but this can become an issue, if the pinctrl driver starts
> to require valid mappings. Additionally, the pin is not protected from
> being remapped later by an other driver.
> 
> There is an external 1kΩ pull-up to 3.3V, so no bias is required on
> the Ethernet PHY's interrupt line.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And queued on at91-4.5-dt.

Thanks! Bye,

> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index e683856c507c..75341eec2dfd 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -308,6 +308,7 @@
>  
>  				pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					pinmux = <PIN_PC9__GPIO>;
> +					bias-disable;
>  				};
>  
>  				pinctrl_pdmic_default: pdmic_default {
>

Patch
diff mbox

diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index e683856c507c..75341eec2dfd 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -308,6 +308,7 @@ 
 
 				pinctrl_macb0_phy_irq: macb0_phy_irq {
 					pinmux = <PIN_PC9__GPIO>;
+					bias-disable;
 				};
 
 				pinctrl_pdmic_default: pdmic_default {