| Message ID | 1455604235-3313-1-git-send-email-mjt@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
On 16.02.2016 07:30, Michael Tokarev wrote: > The comment talks about a non-ELF object while the > example gives ELF object. > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/s390x/ipl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index c9cf7cc..2213405 100644 > --- a/hw/s390x/ipl.c > +++ b/hw/s390x/ipl.c > @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp) > /* Adjust ELF start address to final location */ > ipl->bios_start_addr += fwbase; > } else { > - /* Try to load non-ELF file (e.g. s390-ccw.img) */ > + /* Try to load non-ELF file */ > bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START, > 4096); > ipl->bios_start_addr = ZIPL_IMAGE_START; > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Tue, 16 Feb 2016 09:30:35 +0300 Michael Tokarev <mjt@tls.msk.ru> wrote: > The comment talks about a non-ELF object while the > example gives ELF object. > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/s390x/ipl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index c9cf7cc..2213405 100644 > --- a/hw/s390x/ipl.c > +++ b/hw/s390x/ipl.c > @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp) > /* Adjust ELF start address to final location */ > ipl->bios_start_addr += fwbase; > } else { > - /* Try to load non-ELF file (e.g. s390-ccw.img) */ > + /* Try to load non-ELF file */ > bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START, > 4096); > ipl->bios_start_addr = ZIPL_IMAGE_START; Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index c9cf7cc..2213405 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp) /* Adjust ELF start address to final location */ ipl->bios_start_addr += fwbase; } else { - /* Try to load non-ELF file (e.g. s390-ccw.img) */ + /* Try to load non-ELF file */ bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START, 4096); ipl->bios_start_addr = ZIPL_IMAGE_START;
The comment talks about a non-ELF object while the example gives ELF object. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> --- hw/s390x/ipl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)