diff mbox

[U-Boot] cmd: gpio: Fix 'set' regression

Message ID 1455552175-28210-1-git-send-email-trini@konsulko.com
State Deferred
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini Feb. 15, 2016, 4:02 p.m. UTC
In 0ffe6ab we changed the test for status from the whole word to just
starting with 's' which of course broke 'set', so change the test to
'st' so that it won't catch set (which is still just a test for 's').

Cc: Simon Glass <sjg@chromium.org>
Reported-by: Soeren Moch <smoch@web.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 cmd/gpio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Feb. 15, 2016, 4:16 p.m. UTC | #1
On Mon, Feb 15, 2016 at 11:02:55AM -0500, Tom Rini wrote:

> In 0ffe6ab we changed the test for status from the whole word to just
> starting with 's' which of course broke 'set', so change the test to
> 'st' so that it won't catch set (which is still just a test for 's').
> 
> Cc: Simon Glass <sjg@chromium.org>
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Aaand I see I'm late to the party, oh well.
diff mbox

Patch

diff --git a/cmd/gpio.c b/cmd/gpio.c
index 2b78b16..693998e 100644
--- a/cmd/gpio.c
+++ b/cmd/gpio.c
@@ -141,7 +141,7 @@  static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #endif
 	if (argc > 0)
 		str_gpio = *argv;
-	if (!strncmp(str_cmd, "status", 1)) {
+	if (!strncmp(str_cmd, "status", 2)) {
 		/* Support deprecated gpio_status() */
 #ifdef gpio_status
 		gpio_status();