| Message ID | 1455538154.9793.2.camel@ingics.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Feb 15, 2016 at 1:09 PM, Axel Lin <axel.lin@ingics.com> wrote: > The .direction_output callback should set proper output level. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Obviously correct. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-tpic2810.c b/drivers/gpio/gpio-tpic2810.c index 032d058..9f020aa 100644 --- a/drivers/gpio/gpio-tpic2810.c +++ b/drivers/gpio/gpio-tpic2810.c @@ -33,6 +33,8 @@ struct tpic2810 { struct mutex lock; }; +static void tpic2810_set(struct gpio_chip *chip, unsigned offset, int value); + static int tpic2810_get_direction(struct gpio_chip *chip, unsigned offset) { @@ -51,6 +53,7 @@ static int tpic2810_direction_output(struct gpio_chip *chip, unsigned offset, int value) { /* This device always output */ + tpic2810_set(chip, offset, value); return 0; }
The .direction_output callback should set proper output level. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/gpio/gpio-tpic2810.c | 3 +++ 1 file changed, 3 insertions(+)