diff mbox

[U-Boot,17/30] dm: sandbox: Enable cbfs and cramfs

Message ID 1455502619-16093-18-git-send-email-sjg@chromium.org
State Accepted
Commit 782b97805e9f59cc2b4d3aa67a8a03248e8cd722
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Feb. 15, 2016, 2:16 a.m. UTC
Enable these two filesystems to provide better build coverage in sandbox.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/configs/sandbox.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bin Meng Feb. 16, 2016, 2:51 p.m. UTC | #1
Hi Simon,

On Mon, Feb 15, 2016 at 10:16 AM, Simon Glass <sjg@chromium.org> wrote:
> Enable these two filesystems to provide better build coverage in sandbox.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  include/configs/sandbox.h | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

One comment below:

>
> diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
> index 0f02839..2268c4e 100644
> --- a/include/configs/sandbox.h
> +++ b/include/configs/sandbox.h
> @@ -44,6 +44,9 @@
>  #define CONFIG_CMD_FAT
>  #define CONFIG_CMD_EXT4
>  #define CONFIG_CMD_EXT4_WRITE
> +#define CONFIG_CMD_CBFS
> +#define CONFIG_CMD_CRAMFS
> +#define CONFIG_CRAMFS_CMDLINE

It looks CONFIG_CRAMFS_CMDLINE is nothing but a duplicated macro of
CONFIG_CMD_CRAMFS. Maybe a separate patch to drop
CONFIG_CRAMFS_CMDLINE?

>  #define CONFIG_CMD_PART
>  #define CONFIG_DOS_PARTITION
>  #define CONFIG_HOST_MAX_DEVICES 4
> --

Regards,
Bin
diff mbox

Patch

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
index 0f02839..2268c4e 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
@@ -44,6 +44,9 @@ 
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_EXT4
 #define CONFIG_CMD_EXT4_WRITE
+#define CONFIG_CMD_CBFS
+#define CONFIG_CMD_CRAMFS
+#define CONFIG_CRAMFS_CMDLINE
 #define CONFIG_CMD_PART
 #define CONFIG_DOS_PARTITION
 #define CONFIG_HOST_MAX_DEVICES 4