| Message ID | 1455480259-13433-1-git-send-email-paul.gortmaker@windriver.com |
|---|---|
| State | Accepted |
| Headers | show |
On 14/02/2016 at 15:04:19 -0500, Paul Gortmaker wrote : > The Makefile/Kconfig currently controlling compilation of this code is: > > obj-$(CONFIG_RTC_CLASS) += rtc-core.o > rtc-core-y := class.o interface.o > > drivers/rtc/Kconfig:menuconfig RTC_CLASS > drivers/rtc/Kconfig: bool "Real Time Clock" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the code there is no doubt it is builtin-only. > > We don't replace module.h with init.h since the file does need > to know what a struct module is. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Alessandro Zummo <a.zummo@towertech.it> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Cc: rtc-linux@googlegroups.com > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/rtc/class.c | 13 ------------- > 1 file changed, 13 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index de86578bcd6d..74fd9746aeca 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -361,17 +361,4 @@ static int __init rtc_init(void) rtc_dev_init(); return 0; } - -static void __exit rtc_exit(void) -{ - rtc_dev_exit(); - class_destroy(rtc_class); - ida_destroy(&rtc_ida); -} - subsys_initcall(rtc_init); -module_exit(rtc_exit); - -MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>"); -MODULE_DESCRIPTION("RTC class support"); -MODULE_LICENSE("GPL");
The Makefile/Kconfig currently controlling compilation of this code is: obj-$(CONFIG_RTC_CLASS) += rtc-core.o rtc-core-y := class.o interface.o drivers/rtc/Kconfig:menuconfig RTC_CLASS drivers/rtc/Kconfig: bool "Real Time Clock" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the code there is no doubt it is builtin-only. We don't replace module.h with init.h since the file does need to know what a struct module is. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> Cc: rtc-linux@googlegroups.com Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/rtc/class.c | 13 ------------- 1 file changed, 13 deletions(-)