Patchwork [committed] Fix gcc.c-torture/execute/pr44828.c test case

login
register
mail settings
Submitter Peter Bergner
Date July 8, 2010, 2:24 p.m.
Message ID <1278599052.2773.22.camel@otta>
Download mbox | patch
Permalink /patch/58252/
State New
Headers show

Comments

Peter Bergner - July 8, 2010, 2:24 p.m.
On Wed, 2010-07-07 at 23:17 -0500, Peter Bergner wrote:
> I committed the following patch as obvious to fix running the pr44828.c test
> case on systems that default to unsigned char (eg, powerpc*-linux).

Jakub suggested just changing the formal args and return type to use
explicit signed char which I agree is better, so I've just committed
the following patch to use that.

Peter


2010-07-08  Peter Bergner  <bergner@vnet.ibm.com>

	PR middle-end/44828
	* gcc.c-torture/execute/pr44828.c (foo): Use signed char.
	* gcc.c-torture/execute/pr44828.x: Revert.

Patch

Index: gcc/testsuite/gcc.c-torture/execute/pr44828.c
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/pr44828.c	(revision 161955)
+++ gcc/testsuite/gcc.c-torture/execute/pr44828.c	(working copy)
@@ -1,7 +1,7 @@ 
 extern void abort (void);
 
-static char
-foo (char si1, char si2)
+static signed char
+foo (signed char si1, signed char si2)
 {
   return si1 * si2;
 }
Index: gcc/testsuite/gcc.c-torture/execute/pr44828.x
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/pr44828.x	(revision 161955)
+++ gcc/testsuite/gcc.c-torture/execute/pr44828.x	(working copy)
@@ -1,2 +0,0 @@ 
-set additional_flags "-fsigned-char"
-return 0