| Message ID | 1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Date: Sat, 13 Feb 2016 19:33:15 +0530 > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > with the error: > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > GPIO is now used to reset the switch so we should have a dependency on > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we > can build test it. > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > v2: added COMPILE_TEST and gpio/consumer.h I'm going to apply Arnd's patch because it properly removes the unnecessary linux/gpio.h include. Thanks.
On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: > From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Date: Sat, 13 Feb 2016 19:33:15 +0530 > > > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > > with the error: > > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > > > GPIO is now used to reset the switch so we should have a dependency on > > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we > > can build test it. > > > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > > Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- > > > > v2: added COMPILE_TEST and gpio/consumer.h > > I'm going to apply Arnd's patch because it properly removes the > unnecessary linux/gpio.h include. I think Arnd's patch is still not applied as we are still having build failures for the implicit declarations. Or you want me to send v3 after removing unnecessary linux/gpio.h include? regards suduo
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Date: Fri, 19 Feb 2016 13:59:09 +0530 > On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: >> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> >> Date: Sat, 13 Feb 2016 19:33:15 +0530 >> >> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing >> > with the error: >> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' >> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' ... > I think Arnd's patch is still not applied as we are still having build > failures for the implicit declarations. Or you want me to send v3 after > removing unnecessary linux/gpio.h include? It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23
On Friday 19 February 2016 09:43 PM, David Miller wrote: > From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Date: Fri, 19 Feb 2016 13:59:09 +0530 > >> On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: >>> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com> >>> Date: Sat, 13 Feb 2016 19:33:15 +0530 >>> >>>> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing >>>> with the error: >>>> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' >>>> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > ... >> I think Arnd's patch is still not applied as we are still having build >> failures for the implicit declarations. Or you want me to send v3 after >> removing unnecessary linux/gpio.h include? > > It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23 > Ohhh.. ok.. linux-next is still using net-next from next-20160217, I hope Monday it will be fine. regards sudip
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index f0a7702..186f202 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -262,3 +262,4 @@ endif # PHYLIB config MICREL_KS8995MA tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" depends on SPI + depends on GPIOLIB || COMPILE_TEST diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 5e7340f..55000f6 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -20,6 +20,7 @@ #include <linux/device.h> #include <linux/of.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/of_gpio.h> #include <linux/spi/spi.h>
The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing with the error: drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' GPIO is now used to reset the switch so we should have a dependency on GPIOLIB. While adding the dependency also add COMPILE_TEST so that we can build test it. Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- v2: added COMPILE_TEST and gpio/consumer.h drivers/net/phy/Kconfig | 1 + drivers/net/phy/spi_ks8995.c | 1 + 2 files changed, 2 insertions(+)