| Message ID | 1455312009-808-2-git-send-email-tony@atomide.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Tony, Quoting Tony Lindgren (2016-02-12 13:20:08) > Let's add binding documentation for the ADPLL found on dm814x > and dra62x. The binding uses the standard clock binding. > > Cc: devicetree@vger.kernel.org > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Tero Kristo <t-kristo@ti.com> > Acked-by: Michael Turquette <mturquette@baylibre.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > .../devicetree/bindings/clock/ti/adpll.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/ti/adpll.txt > > diff --git a/Documentation/devicetree/bindings/clock/ti/adpll.txt b/Documentation/devicetree/bindings/clock/ti/adpll.txt > new file mode 100644 > index 0000000..8516bf0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/ti/adpll.txt > @@ -0,0 +1,43 @@ > +Binding for Texas Instruments ADPLL clock. > + > +Binding status: Unstable - ABI compatibility may be broken in the future > + > +This binding uses the common clock binding[1]. It assumes a > +register-mapped ADPLL with two to three selectable input clocks > +and three to four children. > + > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt > + > +Required properties: > +- compatible : shall be one of "ti,dm814-adpll-s-clock" or > + "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL > +- #clock-cells : from common clock binding; shall be set to 0. Thanks for the patch. clock-cells = 1 in both of the examples below (which looks right). > +- clocks : link phandles of parent clocks clkinp and clkinpulow, note > + that the adpll-s-clock also has an optional clkinphif > +- reg : address and length of the register set for controlling the ADPLL. > + > +Examples: > + adpll_mpu_ck: adpll@40 { > + #clock-cells = <1>; > + compatible = "ti,dm814-adpll-s-clock"; > + reg = <0x40 0x40>; > + clocks = <&devosc_ck &devosc_ck &devosc_ck>; > + clock-names = "clkinp", "clkinpulow", "clkinphif"; > + clock-indices = <0>, <1>, <2>, <3>; Why is clock-indices necessary? Best regards, Mike > + clock-output-names = "481c5040.adpll.dcoclkldo", > + "481c5040.adpll.clkout", > + "481c5040.adpll.clkoutx2", > + "481c5040.adpll.clkouthif"; > + }; > + > + adpll_dsp_ck: adpll@80 { > + #clock-cells = <1>; > + compatible = "ti,dm814-adpll-lj-clock"; > + reg = <0x80 0x30>; > + clocks = <&devosc_ck &devosc_ck>; > + clock-names = "clkinp", "clkinpulow"; > + clock-indices = <0>, <1>, <2>; > + clock-output-names = "481c5080.adpll.dcoclkldo", > + "481c5080.adpll.clkout", > + "481c5080.adpll.clkoutldo"; > + }; > -- > 2.7.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Michael Turquette <mturquette@baylibre.com> [160216 17:17]: > Quoting Tony Lindgren (2016-02-12 13:20:08) > > +Required properties: > > +- compatible : shall be one of "ti,dm814-adpll-s-clock" or > > + "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL > > +- #clock-cells : from common clock binding; shall be set to 0. > > Thanks for the patch. > > clock-cells = 1 in both of the examples below (which looks right). Oops thanks, will update to 1. > > +- clocks : link phandles of parent clocks clkinp and clkinpulow, note > > + that the adpll-s-clock also has an optional clkinphif > > +- reg : address and length of the register set for controlling the ADPLL. > > + > > +Examples: > > + adpll_mpu_ck: adpll@40 { > > + #clock-cells = <1>; > > + compatible = "ti,dm814-adpll-s-clock"; > > + reg = <0x40 0x40>; > > + clocks = <&devosc_ck &devosc_ck &devosc_ck>; > > + clock-names = "clkinp", "clkinpulow", "clkinphif"; > > + clock-indices = <0>, <1>, <2>, <3>; > > Why is clock-indices necessary? Hmm yeah I don't think it's needed, so will drop. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/clock/ti/adpll.txt b/Documentation/devicetree/bindings/clock/ti/adpll.txt new file mode 100644 index 0000000..8516bf0 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/ti/adpll.txt @@ -0,0 +1,43 @@ +Binding for Texas Instruments ADPLL clock. + +Binding status: Unstable - ABI compatibility may be broken in the future + +This binding uses the common clock binding[1]. It assumes a +register-mapped ADPLL with two to three selectable input clocks +and three to four children. + +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt + +Required properties: +- compatible : shall be one of "ti,dm814-adpll-s-clock" or + "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL +- #clock-cells : from common clock binding; shall be set to 0. +- clocks : link phandles of parent clocks clkinp and clkinpulow, note + that the adpll-s-clock also has an optional clkinphif +- reg : address and length of the register set for controlling the ADPLL. + +Examples: + adpll_mpu_ck: adpll@40 { + #clock-cells = <1>; + compatible = "ti,dm814-adpll-s-clock"; + reg = <0x40 0x40>; + clocks = <&devosc_ck &devosc_ck &devosc_ck>; + clock-names = "clkinp", "clkinpulow", "clkinphif"; + clock-indices = <0>, <1>, <2>, <3>; + clock-output-names = "481c5040.adpll.dcoclkldo", + "481c5040.adpll.clkout", + "481c5040.adpll.clkoutx2", + "481c5040.adpll.clkouthif"; + }; + + adpll_dsp_ck: adpll@80 { + #clock-cells = <1>; + compatible = "ti,dm814-adpll-lj-clock"; + reg = <0x80 0x30>; + clocks = <&devosc_ck &devosc_ck>; + clock-names = "clkinp", "clkinpulow"; + clock-indices = <0>, <1>, <2>; + clock-output-names = "481c5080.adpll.dcoclkldo", + "481c5080.adpll.clkout", + "481c5080.adpll.clkoutldo"; + };