| Message ID | 1455137922-18060-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
Dear Bernd Kuhls, On Wed, 10 Feb 2016 21:58:41 +0100, Bernd Kuhls wrote: > When libevent was compiled before, links will use it as optional > dependency: > > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/links | grep NEEDED > 0x00000001 (NEEDED) Shared library: [liblzma.so.5] > 0x00000001 (NEEDED) Shared library: [libbz2.so.1.0] > 0x00000001 (NEEDED) Shared library: [libz.so.1] > 0x00000001 (NEEDED) Shared library: [libevent-2.0.so.5] > 0x00000001 (NEEDED) Shared library: [libc.so.1] > > (xz support will be added with the next patch of this series) > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/links/links.mk | 4 ++++ > 1 file changed, 4 insertions(+) I've applied both patches to master. However, could you send another patch that forces --with-<foo>/--without-<foo> ? Since we were not doing that for other dependencies, I applied your patches as-is, but I would like to see those options added explicitly. Thanks! Thomas
Am Tue, 16 Feb 2016 23:11:04 +0100 schrieb Thomas Petazzoni: > I've applied both patches to master. However, could you send another > patch that forces --with-<foo>/--without-<foo> ? Since we were not doing > that for other dependencies, I applied your patches as-is, but I would > like to see those options added explicitly. Hi Thomas, do you prefer the patches for the master or the next branch? Regards, Bernd
diff --git a/package/links/links.mk b/package/links/links.mk index ba55061..b948de4 100644 --- a/package/links/links.mk +++ b/package/links/links.mk @@ -39,6 +39,10 @@ ifeq ($(BR2_PACKAGE_BZIP2),y) LINKS_DEPENDENCIES += bzip2 endif +ifeq ($(BR2_PACKAGE_LIBEVENT),y) +LINKS_DEPENDENCIES += libevent +endif + ifeq ($(BR2_PACKAGE_OPENSSL),y) LINKS_DEPENDENCIES += openssl endif
When libevent was compiled before, links will use it as optional dependency: $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/links | grep NEEDED 0x00000001 (NEEDED) Shared library: [liblzma.so.5] 0x00000001 (NEEDED) Shared library: [libbz2.so.1.0] 0x00000001 (NEEDED) Shared library: [libz.so.1] 0x00000001 (NEEDED) Shared library: [libevent-2.0.so.5] 0x00000001 (NEEDED) Shared library: [libc.so.1] (xz support will be added with the next patch of this series) Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/links/links.mk | 4 ++++ 1 file changed, 4 insertions(+)