diff mbox

ACK: [PATCH 21/21] FADT: remove no longer useful variables from test1

Message ID 56BA797A.5070903@linaro.org
State Rejected
Headers show

Commit Message

Al Stone Feb. 9, 2016, 11:42 p.m. UTC 
On 02/09/2016 05:34 AM, Colin Ian King wrote:
> On 09/02/16 01:33, Al Stone wrote:
>> Now that the tests have been resequenced, added to, and generally
>> overhauled, clean up some variables in test1 that are no longer
>> useful.
>>
>> Signed-off-by: Al Stone <al.stone@linaro.org>
>> ---
>>  src/acpi/fadt/fadt.c | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
>> index 05205cb..fbc71fd 100644
>> --- a/src/acpi/fadt/fadt.c
>> +++ b/src/acpi/fadt/fadt.c
>> @@ -1514,8 +1514,6 @@ static void acpi_table_check_fadt_sleep_status_reg(fwts_framework *fw)
>>  
>>  static int fadt_test1(fwts_framework *fw)
>>  {
>> -	bool passed = true;
>> -
>>  	acpi_table_check_fadt_firmware_ctrl(fw);
>>  	acpi_table_check_fadt_dsdt(fw);
>>  	acpi_table_check_fadt_reserved(fw);
>> @@ -1589,8 +1587,6 @@ static int fadt_test1(fwts_framework *fw)
>>  	 */
>>  	fwts_log_info(fw, "FADT Hypervisor Vendor Identity is %" PRIu64,
>>  		      fadt->hypervisor_id);
>> -	if (passed)
>> -		fwts_passed(fw, "No issues found in FADT table.");
>>  
>>  	return FWTS_OK;
>>  }
>>
> Acked-by: Colin Ian King <colin.king@canonical.com>
> 
> Thanks Al for all these improvements.  Are there any fwts-test patches
> to come later?
> 
> Colin
> 

Argh.  My bad.  I must have missed these the first time through.  So,
attached are the regression test cleanups.  Sorry about that....
diff mbox

Patch

diff --git a/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log
b/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log
index c131850..ab96106 100644
--- a/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log
+++ b/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log
@@ -172,5 +172,6 @@  UEFI tests:
  uefirtvariable  UEFI Runtime service variable interface tests.

 ACPI Spec Compliance tests:
+ fadt            FADT Fixed ACPI Description Table tests.
  madt            MADT Multiple APIC Description Table (spec compliant).
  rsdp            RSDP Root System Description Pointer test.
diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
index 9b7185a..a3ba2fc 100644
--- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
+++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log
@@ -37,8 +37,11 @@  ACPI tests:
   ERST Error Record Serialization Table test.
  facs            (1 test):
   FACS Firmware ACPI Control Structure test.
- fadt            (3 tests):
-  Test FADT ACPI Description Table tests.
+ fadt            (6 tests):
+  ACPI FADT Description Table flag info.
+  FADT checksum test.
+  FADT revision test.
+  ACPI FADT Description Table tests.
   Test FADT SCI_EN bit is enabled.
   Test FADT reset register.
  fpdt            (1 test):
@@ -371,8 +374,11 @@  Batch tests:
   ERST Error Record Serialization Table test.
  facs            (1 test):
   FACS Firmware ACPI Control Structure test.
- fadt            (3 tests):
-  Test FADT ACPI Description Table tests.
+ fadt            (6 tests):
+  ACPI FADT Description Table flag info.
+  FADT checksum test.
+  FADT revision test.
+  ACPI FADT Description Table tests.
   Test FADT SCI_EN bit is enabled.
   Test FADT reset register.
  fan             (2 tests):
@@ -891,6 +897,13 @@  UEFI tests:
   Test UEFI RT service get variable interface, invalid parameters.

 ACPI Spec Compliance tests:
+ fadt            (6 tests):
+  ACPI FADT Description Table flag info.
+  FADT checksum test.
+  FADT revision test.
+  ACPI FADT Description Table tests.
+  Test FADT SCI_EN bit is enabled.
+  Test FADT reset register.
  madt            (5 tests):
   MADT checksum test.
   MADT revision test.