| Message ID | 1455038632-14545-1-git-send-email-javier@osg.samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze: > The S3C Real Time Clock driver requires the clock and source clock to > be defined in the device node but that requirement is not documented. +Cc: Alessandro Zummo No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks but rest of compatible devices need only rtc clock. Best regards, Krzysztof > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > index ac2fcd6ff4b8..1068ffce9f91 100644 > --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > @@ -14,6 +14,10 @@ Required properties: > interrupt number is the rtc alarm interrupt and second interrupt number > is the rtc tick interrupt. The number of cells representing a interrupt > depends on the parent interrupt controller. > +- clocks: Must contain a list of phandle and clock specifier for the rtc > + and source clocks. > +- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the > + same order as the clocks property. > > Example: > > @@ -21,4 +25,6 @@ Example: > compatible = "samsung,s3c6410-rtc"; > reg = <0x10070000 0x100>; > interrupts = <44 0 45 0>; > + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; > + clock-names = "rtc", "rtc_src"; > }; >
Hello Krzysztof, Thanks a lot for your feedback. On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote: > W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze: >> The S3C Real Time Clock driver requires the clock and source clock to >> be defined in the device node but that requirement is not documented. > > +Cc: Alessandro Zummo > I didn't add Alessandro to cc deliberately since Alexandre is the one maintaining the RTC subsystem lately and before that, the RTC patches were picked by Andrew Morton since Alessandro didn't even answer the emails. > No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks > but rest of compatible devices need only rtc clock. > Right, sorry for missing that. I noticed that this patch has already been picked by Rob Herring (I thought it would be picked by Alexandre though) so I will post a follow up patch explaining that rtc_src is only for the s3c6410-rtc compatible. > Best regards, > Krzysztof > Best regards,
On 15/02/2016 at 09:49:34 -0300, Javier Martinez Canillas wrote : > >No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks > >but rest of compatible devices need only rtc clock. > > > > Right, sorry for missing that. I noticed that this patch has already > been picked by Rob Herring (I thought it would be picked by Alexandre > though) so I will post a follow up patch explaining that rtc_src is > only for the s3c6410-rtc compatible. > Yeah, I was going to take it, thanks for pointing out the Rob already has it in his tree.
diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt index ac2fcd6ff4b8..1068ffce9f91 100644 --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt @@ -14,6 +14,10 @@ Required properties: interrupt number is the rtc alarm interrupt and second interrupt number is the rtc tick interrupt. The number of cells representing a interrupt depends on the parent interrupt controller. +- clocks: Must contain a list of phandle and clock specifier for the rtc + and source clocks. +- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the + same order as the clocks property. Example: @@ -21,4 +25,6 @@ Example: compatible = "samsung,s3c6410-rtc"; reg = <0x10070000 0x100>; interrupts = <44 0 45 0>; + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; + clock-names = "rtc", "rtc_src"; };
The S3C Real Time Clock driver requires the clock and source clock to be defined in the device node but that requirement is not documented. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 6 ++++++ 1 file changed, 6 insertions(+)