diff mbox

[v2,6/6] dt-bindings: net: ks8995: add bindings documentation for ks8995

Message ID 1454952937-19428-7-git-send-email-helmut.buchsbaum@gmail.com
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Helmut Buchsbaum Feb. 8, 2016, 5:35 p.m. UTC
Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
---
 .../devicetree/bindings/net/micrel-ks8995.txt        | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt

Comments

Sergei Shtylyov Feb. 8, 2016, 6:44 p.m. UTC | #1
Hello.

On 02/08/2016 08:35 PM, Helmut Buchsbaum wrote:

> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
> ---
>   .../devicetree/bindings/net/micrel-ks8995.txt        | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/net/micrel-ks8995.txt
>
> diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
> new file mode 100644
> index 0000000..7f11ca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
> @@ -0,0 +1,20 @@
> +Micrel KS8995 SPI controlled Ethernet Switch families
> +
> +Required properties (according to spi-bus.txt):
> +- compatible: either "micrel,ks8995", "micrel,ksz8864" or "micrel,ksz8795"
> +
> +Optional properties:
> +- reset-gpios : phandle of gpio that will be used to reset chip during probe
> +
> +Example:
> +
> +spi-master {
> +	...
> +	ksz8795 {

    ePAPR tells to name the nodes generically, according to their function.

> +		compatible = "micrel,ksz8795";
> +
> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +		reset-gpios = <&gpio0 46 1>;
> +	};
> +};

MBR, Sergei
Helmut Buchsbaum Feb. 9, 2016, 8:07 a.m. UTC | #2
On 02/08/2016 07:44 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 02/08/2016 08:35 PM, Helmut Buchsbaum wrote:
>
>> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
>> ---
>>   .../devicetree/bindings/net/micrel-ks8995.txt        | 20
>> ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/net/micrel-ks8995.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>> b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>> new file mode 100644
>> index 0000000..7f11ca6
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>> @@ -0,0 +1,20 @@
>> +Micrel KS8995 SPI controlled Ethernet Switch families
>> +
>> +Required properties (according to spi-bus.txt):
>> +- compatible: either "micrel,ks8995", "micrel,ksz8864" or
>> "micrel,ksz8795"
>> +
>> +Optional properties:
>> +- reset-gpios : phandle of gpio that will be used to reset chip
>> during probe
>> +
>> +Example:
>> +
>> +spi-master {
>> +    ...
>> +    ksz8795 {
>
>     ePAPR tells to name the nodes generically, according to their function.
>
>> +        compatible = "micrel,ksz8795";
>> +
>> +        reg = <0>;
>> +        spi-max-frequency = <50000000>;
>> +        reset-gpios = <&gpio0 46 1>;
>> +    };
>> +};
>
> MBR, Sergei
>
Hello Sergei,

just to avoid any misunderstandings: you refer to ePAPR, ch. 2.2.1 Node 
Names. Your definitely right, I'll correct the naming in my example!

Thanks,
Helmut
Sergei Shtylyov Feb. 9, 2016, 10:43 a.m. UTC | #3
On 2/9/2016 11:07 AM, Helmut Buchsbaum wrote:

>>> Signed-off-by: Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
>>> ---
>>>   .../devicetree/bindings/net/micrel-ks8995.txt        | 20
>>> ++++++++++++++++++++
>>>   1 file changed, 20 insertions(+)
>>>   create mode 100644
>>> Documentation/devicetree/bindings/net/micrel-ks8995.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>>> b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>>> new file mode 100644
>>> index 0000000..7f11ca6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
>>> @@ -0,0 +1,20 @@
>>> +Micrel KS8995 SPI controlled Ethernet Switch families
>>> +
>>> +Required properties (according to spi-bus.txt):
>>> +- compatible: either "micrel,ks8995", "micrel,ksz8864" or
>>> "micrel,ksz8795"
>>> +
>>> +Optional properties:
>>> +- reset-gpios : phandle of gpio that will be used to reset chip
>>> during probe
>>> +
>>> +Example:
>>> +
>>> +spi-master {
>>> +    ...
>>> +    ksz8795 {
>>
>>     ePAPR tells to name the nodes generically, according to their function.
>>
>>> +        compatible = "micrel,ksz8795";
>>> +
>>> +        reg = <0>;
>>> +        spi-max-frequency = <50000000>;
>>> +        reset-gpios = <&gpio0 46 1>;
>>> +    };
>>> +};
>>
>> MBR, Sergei
>>
> Hello Sergei,
>
> just to avoid any misunderstandings: you refer to ePAPR, ch. 2.2.1 Node Names.

    "2.2.2, Generic Names Recommendation", actually. :-)

> Your definitely right, I'll correct the naming in my example!

    TIA.

> Thanks,
> Helmut

MBR, Sergei
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/net/micrel-ks8995.txt b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
new file mode 100644
index 0000000..7f11ca6
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/micrel-ks8995.txt
@@ -0,0 +1,20 @@ 
+Micrel KS8995 SPI controlled Ethernet Switch families
+
+Required properties (according to spi-bus.txt):
+- compatible: either "micrel,ks8995", "micrel,ksz8864" or "micrel,ksz8795"
+
+Optional properties:
+- reset-gpios : phandle of gpio that will be used to reset chip during probe
+
+Example:
+
+spi-master {
+	...
+	ksz8795 {
+		compatible = "micrel,ksz8795";
+
+		reg = <0>;
+		spi-max-frequency = <50000000>;
+		reset-gpios = <&gpio0 46 1>;
+	};
+};