From patchwork Tue Jul 6 15:33:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [15/17] ide: Reject readonly drives unless CD-ROM From: Kevin Wolf X-Patchwork-Id: 58043 Message-Id: <1278430406-18667-16-git-send-email-kwolf@redhat.com> To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org Date: Tue, 6 Jul 2010 17:33:24 +0200 From: Markus Armbruster drive_init() doesn't permit option readonly for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index dbb7acc..3b84bea 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2617,6 +2617,11 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs, if (bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM) { s->drive_kind = IDE_CD; bdrv_set_change_cb(bs, cdrom_change_cb, s); + } else { + if (bdrv_is_read_only(bs)) { + error_report("Can't use a read-only drive"); + return -1; + } } if (serial) { strncpy(s->drive_serial_str, serial, sizeof(s->drive_serial_str));