Message ID | 1454879583-27036-1-git-send-email-afaerber@suse.de |
---|---|
State | New |
Headers | show |
On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaerber@suse.de> wrote: > As preparation for arm64 based mesongxbb, which pulls in this code once > enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. > The loop uses a local unsigned int variable, so adopt that type, > matching the header. > > Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > drivers/clk/meson/clkc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c > index c83ae1367abc..d920d410b51d 100644 > --- a/drivers/clk/meson/clkc.c > +++ b/drivers/clk/meson/clkc.c > @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf, > } > > void __init meson_clk_register_clks(const struct clk_conf *clk_confs, > - size_t nr_confs, > + unsigned int nr_confs, > void __iomem *clk_base) > { > unsigned int i; Nit: I'd prefer to fix declaration in drivers/clk/meson/clkc.h with size_t since we are going to use it for array indexing. Also please, CC linux-meson@googlegroups.com on meson related patches. Thanks!
On Mon, Feb 8, 2016 at 9:34 AM, Carlo Caione <carlo@caione.org> wrote: > On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaerber@suse.de> wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. >> The loop uses a local unsigned int variable, so adopt that type, >> matching the header. >> >> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> drivers/clk/meson/clkc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c >> index c83ae1367abc..d920d410b51d 100644 >> --- a/drivers/clk/meson/clkc.c >> +++ b/drivers/clk/meson/clkc.c >> @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf, >> } >> >> void __init meson_clk_register_clks(const struct clk_conf *clk_confs, >> - size_t nr_confs, >> + unsigned int nr_confs, >> void __iomem *clk_base) >> { >> unsigned int i; > > Nit: I'd prefer to fix declaration in drivers/clk/meson/clkc.h with > size_t since we are going to use it for array indexing. On a second thought it's ok since we use i to cycle through clocks. Acked-by: Carlo Caione <carlo@endlessm.com> Cheers,
Am 08.02.2016 um 09:34 schrieb Carlo Caione: > On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber <afaerber@suse.de> wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. >> The loop uses a local unsigned int variable, so adopt that type, >> matching the header. >> >> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> drivers/clk/meson/clkc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) [...] > Also please, CC linux-meson@googlegroups.com on meson related patches. I used scripts/get_maintainer.pl --nogit-fallback on next-20160111. :) If there is no in-flight patch I've missed, I can send a patch against MAINTAINERS to update it with that list address. Cheers, Andreas
On 02/07, Andreas Färber wrote: > As preparation for arm64 based mesongxbb, which pulls in this code once > enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. > The loop uses a local unsigned int variable, so adopt that type, > matching the header. > > Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- Applied to clk-next. It would have been nice to have the compilation error though
Am 08.02.2016 um 23:15 schrieb Stephen Boyd: > On 02/07, Andreas Färber wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. >> The loop uses a local unsigned int variable, so adopt that type, >> matching the header. >> >> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- > > Applied to clk-next. It would have been nice to have the > compilation error though Ask and you shall receive: CC drivers/clk/meson/clkc.o drivers/clk/meson/clkc.c:200:13: error: conflicting types for 'meson_clk_register_clks' void __init meson_clk_register_clks(const struct clk_conf *clk_confs, ^ In file included from drivers/clk/meson/clkc.c:22:0: drivers/clk/meson/clkc.h:180:6: note: previous declaration of 'meson_clk_register_clks' was here void meson_clk_register_clks(const struct clk_conf *clk_confs, ^ scripts/Makefile.build:258: recipe for target 'drivers/clk/meson/clkc.o' failed make[3]: *** [drivers/clk/meson/clkc.o] Error 1 scripts/Makefile.build:407: recipe for target 'drivers/clk/meson' failed make[2]: *** [drivers/clk/meson] Error 2 scripts/Makefile.build:407: recipe for target 'drivers/clk' failed make[1]: *** [drivers/clk] Error 2 Makefile:959: recipe for target 'drivers' failed make: *** [drivers] Error 2 Not really telling, is it. ;) Regards, Andreas
diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c index c83ae1367abc..d920d410b51d 100644 --- a/drivers/clk/meson/clkc.c +++ b/drivers/clk/meson/clkc.c @@ -198,7 +198,7 @@ meson_clk_register_fixed_rate(const struct clk_conf *clk_conf, } void __init meson_clk_register_clks(const struct clk_conf *clk_confs, - size_t nr_confs, + unsigned int nr_confs, void __iomem *clk_base) { unsigned int i;
As preparation for arm64 based mesongxbb, which pulls in this code once enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. The loop uses a local unsigned int variable, so adopt that type, matching the header. Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/clk/meson/clkc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)