| Message ID | 1454793800-7789-1-git-send-email-robert.jarzmik@free.fr |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Robert Jarzmik <robert.jarzmik@free.fr> Date: Sat, 6 Feb 2016 22:23:20 +0100 > The smc91x driver doesn't honor the probe deferral mechanism when the > interrupt source is not yet available, such as one provided by a gpio > controller not probed. > > Fix this by propagating the platform_get_irq() error code as the probe > return value. > > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- > Since v1: change the irq test to < 0 Applied, thanks.
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 0e2fc1a844ab..db7db8ac4ca3 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -2342,8 +2342,8 @@ static int smc_drv_probe(struct platform_device *pdev) } ndev->irq = platform_get_irq(pdev, 0); - if (ndev->irq <= 0) { - ret = -ENODEV; + if (ndev->irq < 0) { + ret = ndev->irq; goto out_release_io; } /*
The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. Fix this by propagating the platform_get_irq() error code as the probe return value. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- Since v1: change the irq test to < 0 --- drivers/net/ethernet/smsc/smc91x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)