Patchwork Fix io-thread build breakage of a88790a14f

login
register
mail settings
Submitter Jan Kiszka
Date July 6, 2010, 8:49 a.m.
Message ID <4C32EE35.2040607@siemens.com>
Download mbox | patch
Permalink /patch/57986/
State New
Headers show

Comments

Jan Kiszka - July 6, 2010, 8:49 a.m.
Nigel Horne wrote:
> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
> make
> ...
> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
> use in this function)
> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
> reported only once
> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
> 
> Perhaps cpus.c needs to have:
> 
> extern volatile sig_atomic_t exit_request;

Better include the header:

---------->

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 cpus.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Anthony Liguori - July 6, 2010, 3:46 p.m.
On 07/06/2010 03:49 AM, Jan Kiszka wrote:
> Nigel Horne wrote:
>    
>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>> make
>> ...
>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>> use in this function)
>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>> reported only once
>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>
>> Perhaps cpus.c needs to have:
>>
>> extern volatile sig_atomic_t exit_request;
>>      
> Better include the header:
>
> ---------->
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>    

Applied.  Thanks.

In the future, please try to avoid quoting in like this.  I often forget 
to remove it from the commit message before pushing (although I did in 
this case).

Regards,

Anthony Liguori
> ---
>   cpus.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index fcd0f09..eef0bb8 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -30,6 +30,7 @@
>   #include "gdbstub.h"
>   #include "dma.h"
>   #include "kvm.h"
> +#include "exec-all.h"
>
>   #include "cpus.h"
>
>
Jan Kiszka - July 6, 2010, 3:54 p.m.
Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>    
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>>> use in this function)
>>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>>> reported only once
>>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>>
>>> Perhaps cpus.c needs to have:
>>>
>>> extern volatile sig_atomic_t exit_request;
>>>      
>> Better include the header:
>>
>> ---------->
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>    
> 
> Applied.  Thanks.
> 
> In the future, please try to avoid quoting in like this.  I often forget 
> to remove it from the commit message before pushing (although I did in 
> this case).

OK.

Note that there is also 'git am -c' - but I used a non-standard scissors
line here...

Jan

Patch

diff --git a/cpus.c b/cpus.c
index fcd0f09..eef0bb8 100644
--- a/cpus.c
+++ b/cpus.c
@@ -30,6 +30,7 @@ 
 #include "gdbstub.h"
 #include "dma.h"
 #include "kvm.h"
+#include "exec-all.h"
 
 #include "cpus.h"