Patchwork [vect,mips] run the vect testsuite even no paired single support

login
register
mail settings
Submitter Eric Fisher
Date July 5, 2010, 9:29 a.m.
Message ID <AANLkTilAbe0k31bS9-IqNC30xNCSfpVROCfQWrS9_xYx@mail.gmail.com>
Download mbox | patch
Permalink /patch/57883/
State New
Headers show

Comments

Eric Fisher - July 5, 2010, 9:29 a.m.
Hi,

This patch change the vect.exp to run the vect testsuite even the
target has no paired single support.

Tested on ia64 machine:

Running /tools/trunk/gcc/testsuite/gcc.dg/vect/vect.exp ...
FAIL: gcc.dg/vect/pr40254.c execution test

		=== gcc Summary ===

# of expected passes		53
# of unexpected failures	1
# of expected failures		6
# of unsupported tests		487
tools/build-trunk/gcc/xgcc  version 4.6.0 20100630 (experimental) (GCC)


Thanks,
Eric
Diego Novillo - July 5, 2010, 1:31 p.m.
On Mon, Jul 5, 2010 at 05:29, Eric Fisher <joefoxreal@gmail.com> wrote:
> Hi,
>
> This patch change the vect.exp to run the vect testsuite even the
> target has no paired single support.
>
> Tested on ia64 machine:

The code you changed affect mips targets.  How will testing on ia64
help?  Is this a cross compiler?  Additionally, I don't see why the
change is necessary.  You seem to be changing the logic that appends
mpaired-single, not the logic that decides whether to run vect.exp at
all.


Diego.
Eric Fisher - July 6, 2010, 12:46 a.m.
2010/7/5 Diego Novillo <dnovillo@google.com>:
> The code you changed affect mips targets.  How will testing on ia64
> help?  Is this a cross compiler?  Additionally, I don't see why the
> change is necessary.  You seem to be changing the logic that appends
> mpaired-single, not the logic that decides whether to run vect.exp at
> all.

Yes. It's a cross compiler for loongson2f. The original logic will
fall into the 'else' fragment when the target doesn't support
paired-single, hence 'return'. The change will make the test go ahead
even the target doesn't support paired-single such as loongson2f which
has SIMD instructions.

Here is the result for the original testsuite.

Running /tools/trunk/gcc/testsuite/gcc.dg/vect/vect.exp ...

               === gcc Summary ===

/tools/build-trunk/gcc/xgcc  version 4.6.0 20100630 (experimental) (GCC)

Thanks.
Eric

Patch

Index: gcc/testsuite/gcc.dg/vect/vect.exp
===================================================================
--- gcc/testsuite/gcc.dg/vect/vect.exp	(revision 161820)
+++ gcc/testsuite/gcc.dg/vect/vect.exp	(working copy)
@@ -76,10 +76,10 @@  if  [istarget "powerpc-*paired*"]  {
     } else {
 	set dg-do-what-default compile
     }
-} elseif { [istarget "mips*-*-*"]
-	   && [check_effective_target_mpaired_single]
-	   && [check_effective_target_nomips16] } {
-    lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+} elseif { [istarget "mips*-*-*"] && [check_effective_target_nomips16] } {
+    if { [check_effective_target_mpaired_single] } {
+        lappend DEFAULT_VECTCFLAGS "-mpaired-single"
+    }
     set dg-do-what-default run
 } elseif [istarget "sparc*-*-*"] {
     lappend DEFAULT_VECTCFLAGS "-mcpu=ultrasparc" "-mvis"