| Message ID | 1454563862-1971-4-git-send-email-sctincman@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 02/03/2016 10:31 PM, Jonathan Tinkham wrote: > Update device-tree bindings to reflect the rename of the board's > headphone jack. This looks like an incompatible change to the DT. While you've fixed the DT, which will fix new installations, old DTs now won't work. This breaks DT ABI. Any DT change needs to be backwards compatible, i.e. the old name should still work and be documented as a legacy value. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 4, 2016 at 8:39 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 02/03/2016 10:31 PM, Jonathan Tinkham wrote: >> >> Update device-tree bindings to reflect the rename of the board's >> headphone jack. > > > This looks like an incompatible change to the DT. While you've fixed the DT, > which will fix new installations, old DTs now won't work. This breaks DT > ABI. Any DT change needs to be backwards compatible, i.e. the old name > should still work and be documented as a legacy value. > These values are also present in the UCM config for the boards present in alsa-lib/conf/ucm/GoogleNyan It's better not to rely on drivers using a "standard" name, better to let the UCM file abstract it away. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt index c3495be..7ad911f 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt @@ -15,7 +15,7 @@ Required properties: sinks are the MAX98090's pins (as documented in its binding), and the jacks on the board: - * Headphones + * Headphone Jack * Speakers * Mic Jack * Int Mic @@ -36,8 +36,8 @@ sound { nvidia,model = "NVIDIA Tegra Venice2"; nvidia,audio-routing = - "Headphones", "HPR", - "Headphones", "HPL", + "Headphone Jack", "HPR", + "Headphone Jack", "HPL", "Speakers", "SPKR", "Speakers", "SPKL", "Mic Jack", "MICBIAS",
Update device-tree bindings to reflect the rename of the board's headphone jack. Signed-off-by: Jonathan Tinkham <sctincman@gmail.com> --- .../devicetree/bindings/sound/nvidia,tegra-audio-max98090.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)