diff mbox

[U-Boot] .travis.yml: explicitly request sudo

Message ID 1454521294-11937-1-git-send-email-swarren@wwwdotorg.org
State Accepted
Commit e4c1b4d8c1a8d92454f624ffd509057d9bd6ef36
Delegated to: Tom Rini
Headers show

Commit Message

Stephen Warren Feb. 3, 2016, 5:41 p.m. UTC
From: Stephen Warren <swarren@nvidia.com>

Without this, builds default to using new Travis CI infra-structure which
does no allow sudo. The builds need sudo in order to install the ELDK
compilers. Consequently, almost all builds fail without this.

I suspect that existing Travis CI users have not noticed this because
their accounts or builds have been grand-fathered into backwards-
compatible default settings, whereas I just set up a new build from
scratch and received new default settings.

Cc: Wolfgang Denk <wd@denx.de>
Cc: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@ti.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Andreas Färber <afaerber@suse.de>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 .travis.yml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andreas Färber Feb. 3, 2016, 5:44 p.m. UTC | #1
Am 03.02.2016 um 18:41 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Without this, builds default to using new Travis CI infra-structure which
> does no allow sudo. The builds need sudo in order to install the ELDK
> compilers. Consequently, almost all builds fail without this.
> 
> I suspect that existing Travis CI users have not noticed this because
> their accounts or builds have been grand-fathered into backwards-
> compatible default settings, whereas I just set up a new build from
> scratch and received new default settings.
> 
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Andreas Färber <afaerber@suse.de>

Actually I have no clue about Travis...

Cheers,
Andreas

> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  .travis.yml | 2 ++
>  1 file changed, 2 insertions(+)
[snip]
Heiko Schocher Feb. 4, 2016, 9 a.m. UTC | #2
Hello Stephen,

Am 03.02.2016 um 18:41 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> Without this, builds default to using new Travis CI infra-structure which
> does no allow sudo. The builds need sudo in order to install the ELDK
> compilers. Consequently, almost all builds fail without this.
>
> I suspect that existing Travis CI users have not noticed this because
> their accounts or builds have been grand-fathered into backwards-
> compatible default settings, whereas I just set up a new build from
> scratch and received new default settings.
>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>   .travis.yml | 2 ++
>   1 file changed, 2 insertions(+)

Did you tried it with current ML? Or at last with the patch from
Roger?

http://lists.denx.de/pipermail/u-boot/2016-January/243115.html
[U-Boot] [PATCH] .travis.yml: rework according to new travis-ci infra

If I look into:
https://travis-ci.org/u-boot/u-boot

There are only mips and m68k for which the build fail ...

bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 67674e2f5878..8caaeb34553e 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -3,6 +3,8 @@
>
>   # build U-Boot on Travis CI - https://travis-ci.org/
>
> +sudo: true
> +
>   language: c
>
>   addons:
>
Stephen Warren Feb. 4, 2016, 4:33 p.m. UTC | #3
On 02/04/2016 02:00 AM, Heiko Schocher wrote:
> Hello Stephen,
>
> Am 03.02.2016 um 18:41 schrieb Stephen Warren:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Without this, builds default to using new Travis CI infra-structure which
>> does no allow sudo. The builds need sudo in order to install the ELDK
>> compilers. Consequently, almost all builds fail without this.
>>
>> I suspect that existing Travis CI users have not noticed this because
>> their accounts or builds have been grand-fathered into backwards-
>> compatible default settings, whereas I just set up a new build from
>> scratch and received new default settings.
>
> Did you tried it with current ML? Or at last with the patch from
> Roger?
>
> http://lists.denx.de/pipermail/u-boot/2016-January/243115.html
> [U-Boot] [PATCH] .travis.yml: rework according to new travis-ci infra

Both:-) That patch is already applied in mainline, and was included in 
the branch I pushed "to" Travis.

> If I look into:
> https://travis-ci.org/u-boot/u-boot
>
> There are only mips and m68k for which the build fail ...

Yes. With the addition of the sudo tag, the same is now true for my branch.
Heiko Schocher Feb. 5, 2016, 5:30 a.m. UTC | #4
Hello Stephen,

Am 04.02.2016 um 17:33 schrieb Stephen Warren:
> On 02/04/2016 02:00 AM, Heiko Schocher wrote:
>> Hello Stephen,
>>
>> Am 03.02.2016 um 18:41 schrieb Stephen Warren:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> Without this, builds default to using new Travis CI infra-structure which
>>> does no allow sudo. The builds need sudo in order to install the ELDK
>>> compilers. Consequently, almost all builds fail without this.
>>>
>>> I suspect that existing Travis CI users have not noticed this because
>>> their accounts or builds have been grand-fathered into backwards-
>>> compatible default settings, whereas I just set up a new build from
>>> scratch and received new default settings.
>>
>> Did you tried it with current ML? Or at last with the patch from
>> Roger?
>>
>> http://lists.denx.de/pipermail/u-boot/2016-January/243115.html
>> [U-Boot] [PATCH] .travis.yml: rework according to new travis-ci infra
>
> Both:-) That patch is already applied in mainline, and was included in the branch I pushed "to" Travis.
>
>> If I look into:
>> https://travis-ci.org/u-boot/u-boot
>>
>> There are only mips and m68k for which the build fail ...
>
> Yes. With the addition of the sudo tag, the same is now true for my branch.

Great! So I would say:

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Tom Rini Feb. 8, 2016, 8:49 p.m. UTC | #5
On Wed, Feb 03, 2016 at 10:41:34AM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> Without this, builds default to using new Travis CI infra-structure which
> does no allow sudo. The builds need sudo in order to install the ELDK
> compilers. Consequently, almost all builds fail without this.
> 
> I suspect that existing Travis CI users have not noticed this because
> their accounts or builds have been grand-fathered into backwards-
> compatible default settings, whereas I just set up a new build from
> scratch and received new default settings.
> 
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/.travis.yml b/.travis.yml
index 67674e2f5878..8caaeb34553e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,6 +3,8 @@ 
 
 # build U-Boot on Travis CI - https://travis-ci.org/
 
+sudo: true
+
 language: c
 
 addons: