| Message ID | 1454491848-26551-5-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
On 03.02.2016 18:30, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > This is new in this series based on review comment from V1. > You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
Hello Laxman, On 02/03/2016 06:30 AM, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > > --- Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc,
There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no need to get any data from this rtc i2c client, it is not required to set client data for this i2c client. Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@osg.samsung.com> --- This is new in this series based on review comment from V1. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-)