diff mbox

[U-Boot,v3] armv8/ls1043a: Implement workaround for erratum A009660

Message ID 1454383683-1949-1-git-send-email-Mingkai.Hu@freescale.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Mingkai Hu Feb. 2, 2016, 3:28 a.m. UTC
From: Mingkai Hu <mingkai.hu@nxp.com>

Memory controller performance is not optimal with default internal
target queue register value, write required value for optimal DDR
performance.

Signed-off-by: Mingkai Hu <mingkai.hu@nxp.com>
---
v3:
 - Move the macro check to soc.c.

v2: 
 - Add a check to make sure A009660 and A008514 is are not both enabled.
 - Add comment for the offset of eddrtqcr1.

 arch/arm/cpu/armv8/fsl-layerscape/soc.c           | 19 +++++++++++++++++++
 arch/arm/include/asm/arch-fsl-layerscape/config.h |  1 +
 2 files changed, 20 insertions(+)

Comments

York Sun Feb. 24, 2016, 4:47 p.m. UTC | #1
On 02/01/2016 07:36 PM, Mingkai Hu wrote:
> From: Mingkai Hu <mingkai.hu@nxp.com>
> 
> Memory controller performance is not optimal with default internal
> target queue register value, write required value for optimal DDR
> performance.
> 
> Signed-off-by: Mingkai Hu <mingkai.hu@nxp.com>
> ---
> v3:
>  - Move the macro check to soc.c.
> 
> v2: 
>  - Add a check to make sure A009660 and A008514 is are not both enabled.
>  - Add comment for the offset of eddrtqcr1.
> 
>  arch/arm/cpu/armv8/fsl-layerscape/soc.c           | 19 +++++++++++++++++++
>  arch/arm/include/asm/arch-fsl-layerscape/config.h |  1 +
>  2 files changed, 20 insertions(+)
> 

Applied to fsl-qoriq master. Awaiting upstream.

York
diff mbox

Patch

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
index 7ff0148..213ce3a 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
@@ -213,6 +213,24 @@  static void erratum_a009929(void)
 #endif
 }
 
+/*
+ * This erratum requires setting a value to eddrtqcr1 to optimal
+ * the DDR performance. The eddrtqcr1 register is in SCFG space
+ * of LS1043A and the offset is 0x157_020c.
+ */
+#if defined(CONFIG_SYS_FSL_ERRATUM_A009660) \
+	&& defined(CONFIG_SYS_FSL_ERRATUM_A008514)
+#error A009660 and A008514 can not be both enabled.
+#endif
+
+static void erratum_a009660(void)
+{
+#ifdef CONFIG_SYS_FSL_ERRATUM_A009660
+	u32 *eddrtqcr1 = (void *)CONFIG_SYS_FSL_SCFG_ADDR + 0x20c;
+	out_be32(eddrtqcr1, 0x63b20042);
+#endif
+}
+
 void fsl_lsch2_early_init_f(void)
 {
 	struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;
@@ -238,6 +256,7 @@  void fsl_lsch2_early_init_f(void)
 
 	/* Erratum */
 	erratum_a009929();
+	erratum_a009660();
 }
 #endif
 
diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
index f1b164f..7f8de3d 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
@@ -171,6 +171,7 @@ 
 
 #define CONFIG_SYS_FSL_ERRATUM_A009663
 #define CONFIG_SYS_FSL_ERRATUM_A009929
+#define CONFIG_SYS_FSL_ERRATUM_A009660
 #else
 #error SoC not defined
 #endif