| Message ID | 1454359266-4290-1-git-send-email-agraf@suse.de |
|---|---|
| State | Superseded |
| Delegated to: | Minkyu Kang |
| Headers | show |
+Minkyu On 1 February 2016 at 13:41, Alexander Graf <agraf@suse.de> wrote: > Commit 73a1cb27 moved the check whether we should set the architected > timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but > did not update all users of it. > > The one where I (finally) realized why KVM didn't work is the Arndale > board, so this patch adds the respective define to it. > > Signed-off-by: Alexander Graf <agraf@suse.de> > Fixes: 73a1cb27 > --- > include/configs/exynos-common.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h > index 852829c..c4e731f 100644 > --- a/include/configs/exynos-common.h > +++ b/include/configs/exynos-common.h > @@ -31,6 +31,7 @@ > > /* input clock of PLL: 24MHz input clock */ > #define CONFIG_SYS_CLK_FREQ 24000000 > +#define CONFIG_TIMER_CLK_FREQ 24000000 > > #define CONFIG_SETUP_MEMORY_TAGS > #define CONFIG_CMDLINE_TAG > -- > 2.6.2 >
Dear Alexander Graf, On 02/02/16 05:41, Alexander Graf wrote: > Commit 73a1cb27 moved the check whether we should set the architected > timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but > did not update all users of it. > > The one where I (finally) realized why KVM didn't work is the Arndale > board, so this patch adds the respective define to it. > > Signed-off-by: Alexander Graf <agraf@suse.de> > Fixes: 73a1cb27 > --- > include/configs/exynos-common.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h > index 852829c..c4e731f 100644 > --- a/include/configs/exynos-common.h > +++ b/include/configs/exynos-common.h > @@ -31,6 +31,7 @@ > > /* input clock of PLL: 24MHz input clock */ > #define CONFIG_SYS_CLK_FREQ 24000000 > +#define CONFIG_TIMER_CLK_FREQ 24000000 patch looks good but, Please make sure that it doesn't have a different value with system clock, always. (If you expected it) #define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ > > #define CONFIG_SETUP_MEMORY_TAGS > #define CONFIG_CMDLINE_TAG > Thanks, Minkyu Kang.
diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h index 852829c..c4e731f 100644 --- a/include/configs/exynos-common.h +++ b/include/configs/exynos-common.h @@ -31,6 +31,7 @@ /* input clock of PLL: 24MHz input clock */ #define CONFIG_SYS_CLK_FREQ 24000000 +#define CONFIG_TIMER_CLK_FREQ 24000000 #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_CMDLINE_TAG
Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it. The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it. Signed-off-by: Alexander Graf <agraf@suse.de> Fixes: 73a1cb27 --- include/configs/exynos-common.h | 1 + 1 file changed, 1 insertion(+)