diff mbox

[U-Boot] tqma6_wru4: Fix the reset delay for the the LAN8720 PHY

Message ID 1454332799-22003-1-git-send-email-festevam@gmail.com
State Accepted
Commit 755a116e8e09e6b6459b1e968cc21bbfcc0b4b7b
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Feb. 1, 2016, 1:19 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

According to the LAN8720 datasheet tpurstd (time that reset line should
stay asserted) is 25ms.

So do as suggested by the LAN8720 datasheet.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/tqc/tqma6/tqma6_wru4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Feb. 2, 2016, 8:21 p.m. UTC | #1 
On 01/02/2016 14:19, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> According to the LAN8720 datasheet tpurstd (time that reset line should
> stay asserted) is 25ms.
> 
> So do as suggested by the LAN8720 datasheet.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  board/tqc/tqma6/tqma6_wru4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/tqc/tqma6/tqma6_wru4.c b/board/tqc/tqma6/tqma6_wru4.c
> index 4427799..c9a7ab7 100644
> --- a/board/tqc/tqma6/tqma6_wru4.c
> +++ b/board/tqc/tqma6/tqma6_wru4.c
> @@ -177,7 +177,7 @@ static void setup_iomuxc_enet(void)
>  	ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
>  	if (!ret)
>  		gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
> -	udelay(1000);
> +	udelay(25000);
>  	gpio_set_value(ENET_PHY_RESET_GPIO, 1);
>  }
>  
> 
Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/tqc/tqma6/tqma6_wru4.c b/board/tqc/tqma6/tqma6_wru4.c
index 4427799..c9a7ab7 100644
--- a/board/tqc/tqma6/tqma6_wru4.c
+++ b/board/tqc/tqma6/tqma6_wru4.c
@@ -177,7 +177,7 @@  static void setup_iomuxc_enet(void)
 	ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
 	if (!ret)
 		gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
-	udelay(1000);
+	udelay(25000);
 	gpio_set_value(ENET_PHY_RESET_GPIO, 1);
 }