| Message ID | 1454203266-4450-7-git-send-email-vishnupatekar0510@gmail.com |
|---|---|
| State | New |
| Headers | show |
1;4002;0c On Sun, Jan 31, 2016 at 09:20:58AM +0800, Vishnu Patekar wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The A83T does not have a 32.768 kHz low speed oscillator, either as > an external crystal or input. It has a 16 MHz RC-based (inaccurate) > internal oscillator, which is then divided by 512 for a clock close > to 32 kHz. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 8d27b63..45b725c 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -118,6 +118,7 @@ > #size-cells = <1>; > ranges; > > + /* TODO: PRCM block has a mux for this. */ > osc24M: osc24M_clk { > #clock-cells = <0>; > compatible = "fixed-clock"; > @@ -125,11 +126,25 @@ > clock-output-names = "osc24M"; > }; > > - osc32k: osc32k_clk { > + /* > + * This is called "internal OSC" in some places. > + * It is an internal RC-based oscillator. > + * TODO: Its controls are in the PRCM block. > + */ > + osc16M: osc16M_clk { > #clock-cells = <0>; > compatible = "fixed-clock"; > - clock-frequency = <32768>; > - clock-output-names = "osc32k"; > + clock-frequency = <16000000>; > + clock-output-names = "osc16M"; > + }; > + > + osc16Md512: osc16Md512_clk { > + #clock-cells = <0>; > + compatible = "fixed-factor-clock"; > + clock-div = <512>; > + clock-mult = <1>; > + clocks = <&osc16M>; > + clock-output-names = "osc16Md512"; We've been using a dash to separate between the clock and its divider on other SoCs. I changed that and applied the patch. Thanks! Maxime
On Sun, Jan 31, 2016 at 09:20:58AM +0800, Vishnu Patekar wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The A83T does not have a 32.768 kHz low speed oscillator, either as > an external crystal or input. It has a 16 MHz RC-based (inaccurate) > internal oscillator, which is then divided by 512 for a clock close > to 32 kHz. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> You should have your SoB here. Is it ok to add it? Maxime
Hello Maxime, On Tue, Feb 2, 2016 at 9:19 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Sun, Jan 31, 2016 at 09:20:58AM +0800, Vishnu Patekar wrote: >> From: Chen-Yu Tsai <wens@csie.org> >> >> The A83T does not have a 32.768 kHz low speed oscillator, either as >> an external crystal or input. It has a 16 MHz RC-based (inaccurate) >> internal oscillator, which is then divided by 512 for a clock close >> to 32 kHz. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > You should have your SoB here. > > Is it ok to add it? Yes, please add. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 04, 2016 at 04:51:06PM +0800, Vishnu Patekar wrote: > Hello Maxime, > > > On Tue, Feb 2, 2016 at 9:19 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Sun, Jan 31, 2016 at 09:20:58AM +0800, Vishnu Patekar wrote: > >> From: Chen-Yu Tsai <wens@csie.org> > >> > >> The A83T does not have a 32.768 kHz low speed oscillator, either as > >> an external crystal or input. It has a 16 MHz RC-based (inaccurate) > >> internal oscillator, which is then divided by 512 for a clock close > >> to 32 kHz. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > You should have your SoB here. > > > > Is it ok to add it? > Yes, please add. Done, thanks. Maxime
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 8d27b63..45b725c 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -118,6 +118,7 @@ #size-cells = <1>; ranges; + /* TODO: PRCM block has a mux for this. */ osc24M: osc24M_clk { #clock-cells = <0>; compatible = "fixed-clock"; @@ -125,11 +126,25 @@ clock-output-names = "osc24M"; }; - osc32k: osc32k_clk { + /* + * This is called "internal OSC" in some places. + * It is an internal RC-based oscillator. + * TODO: Its controls are in the PRCM block. + */ + osc16M: osc16M_clk { #clock-cells = <0>; compatible = "fixed-clock"; - clock-frequency = <32768>; - clock-output-names = "osc32k"; + clock-frequency = <16000000>; + clock-output-names = "osc16M"; + }; + + osc16Md512: osc16Md512_clk { + #clock-cells = <0>; + compatible = "fixed-factor-clock"; + clock-div = <512>; + clock-mult = <1>; + clocks = <&osc16M>; + clock-output-names = "osc16Md512"; }; };