diff mbox

cpu: microcode: fix a couple of warnings found by cppcheck:

Message ID 1454163073-28410-1-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Jan. 30, 2016, 2:11 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

[src/cpu/microcode/microcode.c:128]: (warning) %x in format string
   (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.
[src/cpu/microcode/microcode.c:157]: (warning) %x in format string
   (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/cpu/microcode/microcode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ivan Hu Feb. 4, 2016, 2:58 a.m. UTC | #1
On 2016年01月30日 22:11, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> [src/cpu/microcode/microcode.c:128]: (warning) %x in format string
>     (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.
> [src/cpu/microcode/microcode.c:157]: (warning) %x in format string
>     (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/cpu/microcode/microcode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
> index f588e1f..7c78b9d 100644
> --- a/src/cpu/microcode/microcode.c
> +++ b/src/cpu/microcode/microcode.c
> @@ -123,7 +123,7 @@ static int microcode_test1(fwts_framework *fw)
>   		ptr = strstr(line, "revision=0x");
>   		if (ptr) {
>   			int cpu;
> -			int revision;
> +			unsigned int revision;
>
>   			if (sscanf(line, "%*s CPU%d sig=0x%*x, pf=0x%*x, revision=0x%x", &cpu, &revision) != 2)
>   				continue;
> @@ -149,7 +149,7 @@ static int microcode_test1(fwts_framework *fw)
>   		ptr = strstr(line, "updated to revision");
>   		if (ptr) {
>   			int cpu;
> -			int revision;
> +			unsigned int revision;
>   			int year;
>   			int month;
>   			int day;
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Feb. 17, 2016, 4:17 a.m. UTC | #2
On 2016-01-30 10:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> [src/cpu/microcode/microcode.c:128]: (warning) %x in format string
>     (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.
> [src/cpu/microcode/microcode.c:157]: (warning) %x in format string
>     (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/cpu/microcode/microcode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
> index f588e1f..7c78b9d 100644
> --- a/src/cpu/microcode/microcode.c
> +++ b/src/cpu/microcode/microcode.c
> @@ -123,7 +123,7 @@ static int microcode_test1(fwts_framework *fw)
>   		ptr = strstr(line, "revision=0x");
>   		if (ptr) {
>   			int cpu;
> -			int revision;
> +			unsigned int revision;
>
>   			if (sscanf(line, "%*s CPU%d sig=0x%*x, pf=0x%*x, revision=0x%x", &cpu, &revision) != 2)
>   				continue;
> @@ -149,7 +149,7 @@ static int microcode_test1(fwts_framework *fw)
>   		ptr = strstr(line, "updated to revision");
>   		if (ptr) {
>   			int cpu;
> -			int revision;
> +			unsigned int revision;
>   			int year;
>   			int month;
>   			int day;
>

Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c
index f588e1f..7c78b9d 100644
--- a/src/cpu/microcode/microcode.c
+++ b/src/cpu/microcode/microcode.c
@@ -123,7 +123,7 @@  static int microcode_test1(fwts_framework *fw)
 		ptr = strstr(line, "revision=0x");
 		if (ptr) {
 			int cpu;
-			int revision;
+			unsigned int revision;
 
 			if (sscanf(line, "%*s CPU%d sig=0x%*x, pf=0x%*x, revision=0x%x", &cpu, &revision) != 2)
 				continue;
@@ -149,7 +149,7 @@  static int microcode_test1(fwts_framework *fw)
 		ptr = strstr(line, "updated to revision");
 		if (ptr) {
 			int cpu;
-			int revision;
+			unsigned int revision;
 			int year;
 			int month;
 			int day;