From patchwork Thu Jul 1 11:11:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 57536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 393761007D2 for ; Thu, 1 Jul 2010 21:13:23 +1000 (EST) Received: from localhost ([127.0.0.1]:33795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUHhn-0003qb-TY for incoming@patchwork.ozlabs.org; Thu, 01 Jul 2010 07:13:19 -0400 Received: from [140.186.70.92] (port=37644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUHgI-0003nH-BF for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUHgH-0007SM-6A for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39553) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUHgG-0007S1-Ux for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:45 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o61BBio2006786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Jul 2010 07:11:44 -0400 Received: from localhost.localdomain (dhcp-5-217.str.redhat.com [10.32.5.217]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o61BBdF0008946; Thu, 1 Jul 2010 07:11:43 -0400 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Thu, 1 Jul 2010 13:11:33 +0200 Message-Id: <1277982694-28563-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1277982694-28563-1-git-send-email-kwolf@redhat.com> References: <1277982694-28563-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: kwolf@redhat.com Subject: [Qemu-devel] [PATCH v2 3/4] blkdebug: Free QemuOpts after having read the config X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Forgetting to free them means that the next instance inherits all rules and gets its own rules only additionally. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 4ec8ca6..78cbff4 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -267,6 +267,8 @@ static int read_config(BDRVBlkdebugState *s, const char *filename) ret = 0; fail: + qemu_opts_reset(&inject_error_opts); + qemu_opts_reset(&set_state_opts); fclose(f); return ret; }