| Message ID | 20100701094552.GA6188@hera.kernel.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Denis Kirjanov <dkirjanov@hera.kernel.org> Date: Thu, 1 Jul 2010 09:45:52 +0000 > Use kfree_skb for skb pointers > > Acked-by: Dimitris Michailidis <dm@chelsio.com> > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> The code is completely different in this part of the driver now, this patch does not apply. In fact there is no reference to the string "kfree" at all in the l2t.c file of the cxgb4 driver :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: Denis Kirjanov <dkirjanov@hera.kernel.org> > Date: Thu, 1 Jul 2010 09:45:52 +0000 > > > Use kfree_skb for skb pointers > > > > Acked-by: Dimitris Michailidis <dm@chelsio.com> > > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> > > The code is completely different in this part of the driver now, this > patch does not apply. > > In fact there is no reference to the string "kfree" at all in the > l2t.c file of the cxgb4 driver :) This patch is for net-next and it should apply there, I see the wrong kfree (there's only one kfree). Denis didn't mention net-next, maybe you tried to apply it to net-2.6? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Dimitrios Michailidis" <dm@chelsio.com> Date: Fri, 2 Jul 2010 22:51:17 -0700 > >> From: Denis Kirjanov <dkirjanov@hera.kernel.org> >> Date: Thu, 1 Jul 2010 09:45:52 +0000 >> >> > Use kfree_skb for skb pointers >> > >> > Acked-by: Dimitris Michailidis <dm@chelsio.com> >> > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> >> >> The code is completely different in this part of the driver now, this >> patch does not apply. >> >> In fact there is no reference to the string "kfree" at all in the >> l2t.c file of the cxgb4 driver :) > > This patch is for net-next and it should apply there, I see the wrong > kfree (there's only one kfree). Denis didn't mention net-next, maybe > you tried to apply it to net-2.6? Yes, I did. That's why people should always indicate what tree a patch is for in the subject line or similar. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/03/2010 10:43 AM, David Miller wrote: > From: "Dimitrios Michailidis"<dm@chelsio.com> > Date: Fri, 2 Jul 2010 22:51:17 -0700 > >> >>> From: Denis Kirjanov<dkirjanov@hera.kernel.org> >>> Date: Thu, 1 Jul 2010 09:45:52 +0000 >>> >>>> Use kfree_skb for skb pointers >>>> >>>> Acked-by: Dimitris Michailidis<dm@chelsio.com> >>>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org> >>> >>> The code is completely different in this part of the driver now, this >>> patch does not apply. >>> >>> In fact there is no reference to the string "kfree" at all in the >>> l2t.c file of the cxgb4 driver :) >> >> This patch is for net-next and it should apply there, I see the wrong >> kfree (there's only one kfree). Denis didn't mention net-next, maybe >> you tried to apply it to net-2.6? > > Yes, I did. > > That's why people should always indicate what tree a patch is for > in the subject line or similar. > Yes, I'll be more accurate next time. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/cxgb4/l2t.c b/drivers/net/cxgb4/l2t.c index 5b990d2..e8f0f55 100644 --- a/drivers/net/cxgb4/l2t.c +++ b/drivers/net/cxgb4/l2t.c @@ -314,7 +314,7 @@ static void t4_l2e_free(struct l2t_entry *e) struct sk_buff *skb = e->arpq_head; e->arpq_head = skb->next; - kfree(skb); + kfree_skb(skb); } e->arpq_tail = NULL; }