[11/31] Add debugger entry points for ARC
diff mbox

Message ID 1454010404-28845-1-git-send-email-jeffmerkey@gmail.com
State Not Applicable
Headers show

Commit Message

Jeffrey Merkey Jan. 28, 2016, 7:46 p.m. UTC
This patch series adds an export which can be set by system debuggers to
direct the hard lockup and soft lockup detector to trigger a breakpoint
exception and enter a debugger if one is active.  It is assumed that if
someone sets this variable, then an breakpoint handler of some sort will
be actively loaded or registered via the notify die handler chain.

This addition is extremely useful for debugging hard and soft lockups
real time and quickly from a console debugger.

Signed-off-by: Jeffrey Merkey <jeffmerkey@gmail.com>
---
 arch/arc/include/asm/kdebug.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Vineet Gupta Feb. 1, 2016, 9:56 a.m. UTC | #1
On Friday 29 January 2016 01:16 AM, Jeffrey Merkey wrote:
> This patch series adds an export which can be set by system debuggers to
> direct the hard lockup and soft lockup detector to trigger a breakpoint
> exception and enter a debugger if one is active.  It is assumed that if
> someone sets this variable, then an breakpoint handler of some sort will
> be actively loaded or registered via the notify die handler chain.
>
> This addition is extremely useful for debugging hard and soft lockups
> real time and quickly from a console debugger.
>
> Signed-off-by: Jeffrey Merkey <jeffmerkey@gmail.com>

To reduce duplication, maybe later this could be used to replace
arch_kgdb_breakpoint()

Acked-by: Vineet Gupta <vgupta@synopsys.com>
Jeff Merkey Feb. 1, 2016, 4:04 p.m. UTC | #2
On 2/1/16, Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> On Friday 29 January 2016 01:16 AM, Jeffrey Merkey wrote:
>> This patch series adds an export which can be set by system debuggers to
>> direct the hard lockup and soft lockup detector to trigger a breakpoint
>> exception and enter a debugger if one is active.  It is assumed that if
>> someone sets this variable, then an breakpoint handler of some sort will
>> be actively loaded or registered via the notify die handler chain.
>>
>> This addition is extremely useful for debugging hard and soft lockups
>> real time and quickly from a console debugger.
>>
>> Signed-off-by: Jeffrey Merkey <jeffmerkey@gmail.com>
>
> To reduce duplication, maybe later this could be used to replace
> arch_kgdb_breakpoint()
>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
>

You can drop this patch series, I am rethinking a better way to do this.

Jeff

Patch
diff mbox

diff --git a/arch/arc/include/asm/kdebug.h b/arch/arc/include/asm/kdebug.h
index 3fbe6c4..f476ed7 100644
--- a/arch/arc/include/asm/kdebug.h
+++ b/arch/arc/include/asm/kdebug.h
@@ -16,4 +16,8 @@  enum die_val {
 	DIE_OOPS
 };
 
+static inline void arch_breakpoint(void)
+{
+	__asm__ __volatile__ ("trap_s	0x4\n");
+}
 #endif