From patchwork Wed Jun 30 11:55:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [02/11] block migration: Fix test for read-only drive Date: Wed, 30 Jun 2010 01:55:33 -0000 From: Markus Armbruster X-Patchwork-Id: 57393 Message-Id: <1277898942-6501-3-git-send-email-armbru@redhat.com> To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, hch@lst.de init_blk_migration_it() skips drives with type hint BDRV_TYPE_CDROM. The intention is to skip read-only drives. However, BDRV_TYPE_CDROM is only a hint. It is currently sufficent for read-only. But it's not necessary, and it may not remain sufficient. Use bdrv_is_read_only() instead. Signed-off-by: Markus Armbruster --- block-migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block-migration.c b/block-migration.c index 7d04d6d..7337349 100644 --- a/block-migration.c +++ b/block-migration.c @@ -236,7 +236,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs) BlkMigDevState *bmds; int64_t sectors; - if (bs->type == BDRV_TYPE_HD) { + if (!bdrv_is_read_only(bs)) { sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS; if (sectors == 0) { return;