| Message ID | CAFULd4a0MHKGY7LcL7KD42jqS6Xj3todTcjs7b4e5tk3+gJDHA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Jan 27, 2016, at 12:58 AM, Uros Bizjak <ubizjak@gmail.com> wrote: > 2016-01-27 Uros Bizjak <ubizjak@gmail.com> > > * gcc.dg/torture/pr68264.c: Disable log1p test for glibc < 2.22 > and expm1 test for glibc < 2.11. > > Tested on x86_64-linux-gnu, CentOS 5.11 and Fedora 23. > > OK for mainline? So, unless we have a glibc style person that wants to comment further on it, I think the patch is Ok. The only part I was worried about, is that you included defined(__GLIBC__) &&, and you did. Darwin and newlib for example, won’t define that. You also included the glibc bug number, which is excellent.
diff --git a/gcc/testsuite/gcc.dg/torture/pr68264.c b/gcc/testsuite/gcc.dg/torture/pr68264.c index 8396b34..9294d5a 100644 --- a/gcc/testsuite/gcc.dg/torture/pr68264.c +++ b/gcc/testsuite/gcc.dg/torture/pr68264.c @@ -74,8 +74,10 @@ test (void) #endif TEST (log2 (d), LARGE_NEG_EDOM); TEST (log10 (d), LARGE_NEG_EDOM); - /* Disabled due to glibc PR 6792, fixed in Apr 2015. */ +#if defined(__GLIBC__) && (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ < 22)) + /* Disabled due to glibc PR 6792, fixed in glibc 2.22. */ if (0) +#endif TEST (log1p (d), LARGE_NEG_EDOM); TEST (exp (d), POWER_ERANGE); #if (defined (__sun__) || defined(__hppa__)) && defined (__unix__) @@ -85,7 +87,11 @@ test (void) #endif { TEST (exp2 (d), POWER_ERANGE); - TEST (expm1 (d), POWER_ERANGE); +#if defined(__GLIBC__) && (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ < 11)) + /* Disabled due to glibc PR 6788, fixed in glibc 2.11. */ + if (0) +#endif + TEST (expm1 (d), POWER_ERANGE); } TEST (sqrt (d), LARGE_NEG_EDOM); TEST (pow (100.0, d), POWER_ERANGE);
2016-01-27 Uros Bizjak <ubizjak@gmail.com> * gcc.dg/torture/pr68264.c: Disable log1p test for glibc < 2.22 and expm1 test for glibc < 2.11. Tested on x86_64-linux-gnu, CentOS 5.11 and Fedora 23. OK for mainline? Uros.