| Message ID | 1453855080-17760-2-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Hi John: Welcome. One nit. On 2016年01月27日 08:37, John Stultz wrote: > Add device tree binding document for reboot-mode driver Maybe you want to use "sram-reboot-mode" instead of "reboot-mode" here. > > Cc: Andy Yan <andy.yan@rock-chips.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Thierry Reding <treding@nvidia.com> > Cc: Heiko Stübner <heiko@sntech.de> > Cc: Caesar Wang <wxt@rock-chips.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Guodong Xu <guodong.xu@linaro.org> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Vishal Bhoj <vishal.bhoj@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: devicetree@vger.kernel.org > Cc: Android Kernel Team <kernel-team@android.com> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > .../bindings/power/reset/sram-reboot-mode.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt > new file mode 100644 > index 0000000..33bb132 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt > @@ -0,0 +1,47 @@ > +SRAM reboot mode driver > + > +This driver get reboot mode magic value form reboot-mode driver > +and stores it in a SRAM address. Then the bootloader > +can read it and take different action according to the magic > +value stored. > + > +This DT node should be represented as a sub-node of a "mmio-sram", "simple-bus" > +node. > + > +Required properties: > +- compatible: should be "sram-reboot-mode" > +- reg: offset from the sram range where to store the magic value(in bytes) > + > +The rest of the properties should follow the generic reboot-mode discription > +found in reboot-mode.txt > + > +Example: > + > + sram@5f01000 { > + compatible = "mmio-sram", "simple-bus"; > + reg = <0x0 0x05f01000 0x0 0x00001000>; > + ranges = <0x0 0x0 0x05f01000 0x00001000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + reboot-mode@0 { > + compatible = "sram-reboot-mode"; > + reg = <0x0 0x4>; > + > + none { > + linux,mode = "none"; > + loader,magic = <0x77665501>; > + }; > + > + bootloader { > + linux,mode = "bootloader"; > + loader,magic = <0x77665500>; > + }; > + > + recovery { > + linux,mode = "recovery"; > + loader,magic = <0x77665502>; > + }; > + }; > + }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt new file mode 100644 index 0000000..33bb132 --- /dev/null +++ b/Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt @@ -0,0 +1,47 @@ +SRAM reboot mode driver + +This driver get reboot mode magic value form reboot-mode driver +and stores it in a SRAM address. Then the bootloader +can read it and take different action according to the magic +value stored. + +This DT node should be represented as a sub-node of a "mmio-sram", "simple-bus" +node. + +Required properties: +- compatible: should be "sram-reboot-mode" +- reg: offset from the sram range where to store the magic value(in bytes) + +The rest of the properties should follow the generic reboot-mode discription +found in reboot-mode.txt + +Example: + + sram@5f01000 { + compatible = "mmio-sram", "simple-bus"; + reg = <0x0 0x05f01000 0x0 0x00001000>; + ranges = <0x0 0x0 0x05f01000 0x00001000>; + + #address-cells = <1>; + #size-cells = <1>; + + reboot-mode@0 { + compatible = "sram-reboot-mode"; + reg = <0x0 0x4>; + + none { + linux,mode = "none"; + loader,magic = <0x77665501>; + }; + + bootloader { + linux,mode = "bootloader"; + loader,magic = <0x77665500>; + }; + + recovery { + linux,mode = "recovery"; + loader,magic = <0x77665502>; + }; + }; + };
Add device tree binding document for reboot-mode driver Cc: Andy Yan <andy.yan@rock-chips.com> Cc: Rob Herring <robh@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Thierry Reding <treding@nvidia.com> Cc: Heiko Stübner <heiko@sntech.de> Cc: Caesar Wang <wxt@rock-chips.com> Cc: Kees Cook <keescook@chromium.org> Cc: Guodong Xu <guodong.xu@linaro.org> Cc: Haojian Zhuang <haojian.zhuang@linaro.org> Cc: Vishal Bhoj <vishal.bhoj@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: devicetree@vger.kernel.org Cc: Android Kernel Team <kernel-team@android.com> Signed-off-by: John Stultz <john.stultz@linaro.org> --- .../bindings/power/reset/sram-reboot-mode.txt | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/sram-reboot-mode.txt