diff mbox

[4.9,rs6000,testsuite] Fix PR69479

Message ID 1453844803.31883.3.camel@gnopaine
State New
Headers show

Commit Message

Bill Schmidt Jan. 26, 2016, 9:46 p.m. UTC
Hi,

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69479 notes that
gcc.dg/and-1.c fails a scan-assembler-not test for nand, but the test
does pass in subsequent releases.  The test author indicates in comment
#1 that we can just remove this test for powerpc*-*-*, which this patch
does.  Verified for 4.9 on powerpc64le-unknown-linux-gnu.  Ok to commit
to that branch?

Thanks,
Bill


2016-01-26  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* gcc.dg/and-1.c: Remove nand test for powerpc*-*-*.

Comments

David Edelsohn Jan. 26, 2016, 10:38 p.m. UTC | #1
On Tue, Jan 26, 2016 at 4:46 PM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69479 notes that
> gcc.dg/and-1.c fails a scan-assembler-not test for nand, but the test
> does pass in subsequent releases.  The test author indicates in comment
> #1 that we can just remove this test for powerpc*-*-*, which this patch
> does.  Verified for 4.9 on powerpc64le-unknown-linux-gnu.  Ok to commit
> to that branch?
>
> Thanks,
> Bill
>
>
> 2016-01-26  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
>
>         * gcc.dg/and-1.c: Remove nand test for powerpc*-*-*.

Please use an XFAIL, not removing the target from the test.

Thanks, David
David Edelsohn Jan. 27, 2016, 1:38 p.m. UTC | #2
On Tue, Jan 26, 2016 at 4:46 PM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69479 notes that
> gcc.dg/and-1.c fails a scan-assembler-not test for nand, but the test
> does pass in subsequent releases.  The test author indicates in comment
> #1 that we can just remove this test for powerpc*-*-*, which this patch
> does.  Verified for 4.9 on powerpc64le-unknown-linux-gnu.  Ok to commit
> to that branch?
>
> Thanks,
> Bill
>
>
> 2016-01-26  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
>
>         * gcc.dg/and-1.c: Remove nand test for powerpc*-*-*.

Sigh. This testcase should have been placed in gcc.target.

This patch is okay.

Thanks, David
diff mbox

Patch

Index: gcc/testsuite/gcc.dg/and-1.c
===================================================================
--- gcc/testsuite/gcc.dg/and-1.c	(revision 232844)
+++ gcc/testsuite/gcc.dg/and-1.c	(working copy)
@@ -1,8 +1,8 @@ 
 /* { dg-do compile } */
 /* { dg-options "-O2" } */
 /* { dg-final { scan-assembler "and" { target powerpc*-*-* spu-*-* } } } */
-/* There should be no nand for this testcase (for either PPC or SPU). */
-/* { dg-final { scan-assembler-not "nand" { target powerpc*-*-* spu-*-* } } } */
+/* There should be no nand for this testcase for SPU. */
+/* { dg-final { scan-assembler-not "nand" { target spu-*-* } } } */
 
 int f(int y)
 {