diff mbox

[U-Boot] net: eepro100: Fix build warnings

Message ID 1453713986-28374-1-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit e6655d7c23b5645602f6b1143d5e6ec858e3a431
Delegated to: Tom Rini
Headers show

Commit Message

Bin Meng Jan. 25, 2016, 9:26 a.m. UTC
When building katmai, it reports quite a lot

  warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Fix this by casting the dev->iobase with u_long.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/net/eepro100.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Joe Hershberger Jan. 25, 2016, 2:46 p.m. UTC | #1
On Mon, Jan 25, 2016 at 3:26 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> When building katmai, it reports quite a lot
>
>   warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> Fix this by casting the dev->iobase with u_long.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini Jan. 25, 2016, 9:30 p.m. UTC | #2
On Mon, Jan 25, 2016 at 01:26:26AM -0800, Bin Meng wrote:

> When building katmai, it reports quite a lot
> 
>   warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 
> Fix this by casting the dev->iobase with u_long.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/net/eepro100.c b/drivers/net/eepro100.c
index f2cd32c..d4a6386 100644
--- a/drivers/net/eepro100.c
+++ b/drivers/net/eepro100.c
@@ -240,23 +240,23 @@  static void eepro100_halt (struct eth_device *dev);
 
 static inline int INW (struct eth_device *dev, u_long addr)
 {
-	return le16_to_cpu (*(volatile u16 *) (addr + dev->iobase));
+	return le16_to_cpu(*(volatile u16 *)(addr + (u_long)dev->iobase));
 }
 
 static inline void OUTW (struct eth_device *dev, int command, u_long addr)
 {
-	*(volatile u16 *) ((addr + dev->iobase)) = cpu_to_le16 (command);
+	*(volatile u16 *)((addr + (u_long)dev->iobase)) = cpu_to_le16(command);
 }
 
 static inline void OUTL (struct eth_device *dev, int command, u_long addr)
 {
-	*(volatile u32 *) ((addr + dev->iobase)) = cpu_to_le32 (command);
+	*(volatile u32 *)((addr + (u_long)dev->iobase)) = cpu_to_le32(command);
 }
 
 #if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
 static inline int INL (struct eth_device *dev, u_long addr)
 {
-	return le32_to_cpu (*(volatile u32 *) (addr + dev->iobase));
+	return le32_to_cpu(*(volatile u32 *)(addr + (u_long)dev->iobase));
 }
 
 static int get_phyreg (struct eth_device *dev, unsigned char addr,