Patchwork mtd: cfi_probe: print manufacturer and id of probed chip

login
register
mail settings
Submitter Guillaume LECERF
Date June 29, 2010, 8:32 a.m.
Message ID <20100629083204.11146.37097.stgit@dev.siriade.com>
Download mbox | patch
Permalink /patch/57253/
State Accepted
Commit 771a115a6df06c45cf783e24c3f1f08b3e9aac4c
Headers show

Comments

Guillaume LECERF - June 29, 2010, 8:32 a.m.
2010/6/29 Artem Bityutskiy <dedekind1@gmail.com>:
> This is not a debugging print, so I think you should do it in a more
> user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x".

OK, here it is again.

Signed-off-by: Guillaume LECERF <glecerf@gmail.com>
---
 drivers/mtd/chips/cfi_probe.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Artem Bityutskiy - July 13, 2010, 9:54 a.m.
On Tue, 2010-06-29 at 10:32 +0200, Guillaume LECERF wrote:
> 2010/6/29 Artem Bityutskiy <dedekind1@gmail.com>:
> > This is not a debugging print, so I think you should do it in a more
> > user-friendly way. E.g., "manufect. ID %#08x, chip id %#08x".
> 
> OK, here it is again.
> 
> Signed-off-by: Guillaume LECERF <glecerf@gmail.com>

Pushed to l2-mtd-2.6.git / master

Patch

diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index b2acd32..8f5b96a 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -235,9 +235,9 @@  static int __xipram cfi_chip_setup(struct map_info *map,
 	cfi_qry_mode_off(base, map, cfi);
 	xip_allowed(base, map);
 
-	printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank\n",
+	printk(KERN_INFO "%s: Found %d x%d devices at 0x%x in %d-bit bank. Manufacturer ID %#08x Chip ID %#08x\n",
 	       map->name, cfi->interleave, cfi->device_type*8, base,
-	       map->bankwidth*8);
+	       map->bankwidth*8, cfi->mfr, cfi->id);
 
 	return 1;
 }