diff mbox

[04/21] docs/manual: document usage of BR2_TOOLCHAIN_HAS_SYNC_x

Message ID 1453676887-31236-5-git-send-email-thomas.petazzoni@free-electrons.com
State Superseded
Headers show

Commit Message

Thomas Petazzoni Jan. 24, 2016, 11:07 p.m. UTC
This commit updates the documentation to detail when and how to use
the BR2_TOOLCHAIN_HAS_SYNC_x dependency. Note that we chose to not add
a comment about this dependency, because it is mainly tied to
architecture capabilities (except in very specific cases, which would
be way too complicated to explain in a Config.in comment).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 docs/manual/adding-packages-directory.txt | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Yann E. MORIN Jan. 25, 2016, 6:38 p.m. UTC | #1
Thomas, All,

On 2016-01-25 00:07 +0100, Thomas Petazzoni spake thusly:
> This commit updates the documentation to detail when and how to use
> the BR2_TOOLCHAIN_HAS_SYNC_x dependency. Note that we chose to not add
> a comment about this dependency, because it is mainly tied to
> architecture capabilities (except in very specific cases, which would
> be way too complicated to explain in a Config.in comment).
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  docs/manual/adding-packages-directory.txt | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> index b9596a2..cd78390 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -279,6 +279,19 @@ use in the comment.
>  ** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
>  ** Comment string: no comment to be added
>  
> +* Gcc +__sync_*+ built-ins used for atomic operations. They are
> +  available in variants operating on 1 byte, 2 bytes, 4 bytes and 8
> +  bytes. Since different architectures support atomic operations on
> +  different sizes, one dependency symbol is available for each size:
> +** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+ for 1 byte,
> +   +BR2_TOOLCHAIN_HAS_SYNC_2+ for two bytes,
> +   +BR2_TOOLCHAIN_HAS_SYNC_4+ for 4 bytes, +BR2_TOOLCHAIN_HAS_SYNC_8+
> +   for 8 bytes.
> +** Comment string: no comment to be added
> +
> +* One byte +__sync_*+ gcc built-in for atomic instructions
> +** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+

I don't see why you specifically documment BR2_TOOLCHAIN_HAS_SYNC_1
separately. Did I miss something, or is it a stray attempt?

Regards,
Yann E. MORIN.

>  * Kernel headers
>  ** Dependency symbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace
>     +X_Y+ with the proper version, see +toolchain/toolchain-common.in+)
> -- 
> 2.6.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Jan. 25, 2016, 8:07 p.m. UTC | #2
Yann,

On Mon, 25 Jan 2016 19:38:37 +0100, Yann E. MORIN wrote:

> > +* Gcc +__sync_*+ built-ins used for atomic operations. They are
> > +  available in variants operating on 1 byte, 2 bytes, 4 bytes and 8
> > +  bytes. Since different architectures support atomic operations on
> > +  different sizes, one dependency symbol is available for each size:
> > +** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+ for 1 byte,
> > +   +BR2_TOOLCHAIN_HAS_SYNC_2+ for two bytes,
> > +   +BR2_TOOLCHAIN_HAS_SYNC_4+ for 4 bytes, +BR2_TOOLCHAIN_HAS_SYNC_8+
> > +   for 8 bytes.
> > +** Comment string: no comment to be added
> > +
> > +* One byte +__sync_*+ gcc built-in for atomic instructions
> > +** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+
> 
> I don't see why you specifically documment BR2_TOOLCHAIN_HAS_SYNC_1
> separately. Did I miss something, or is it a stray attempt?

It's a stray attempt :-/ Will fix in v2, thanks for spotting!

Thomas
diff mbox

Patch

diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index b9596a2..cd78390 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -279,6 +279,19 @@  use in the comment.
 ** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
 ** Comment string: no comment to be added
 
+* Gcc +__sync_*+ built-ins used for atomic operations. They are
+  available in variants operating on 1 byte, 2 bytes, 4 bytes and 8
+  bytes. Since different architectures support atomic operations on
+  different sizes, one dependency symbol is available for each size:
+** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+ for 1 byte,
+   +BR2_TOOLCHAIN_HAS_SYNC_2+ for two bytes,
+   +BR2_TOOLCHAIN_HAS_SYNC_4+ for 4 bytes, +BR2_TOOLCHAIN_HAS_SYNC_8+
+   for 8 bytes.
+** Comment string: no comment to be added
+
+* One byte +__sync_*+ gcc built-in for atomic instructions
+** Dependency symbol: +BR2_TOOLCHAIN_HAS_SYNC_1+
+
 * Kernel headers
 ** Dependency symbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace
    +X_Y+ with the proper version, see +toolchain/toolchain-common.in+)