Patchwork [Bug,584143] Re: qemu fails to set hdd serial number

login
register
mail settings
Submitter Коренберг Марк
Date June 29, 2010, 7:31 a.m.
Message ID <20100629073119.18635.99210.malone@wampee.canonical.com>
Download mbox | patch
Permalink /patch/57247/
State New
Headers show

Comments

Коренберг Марк - June 29, 2010, 7:31 a.m.
-drive file=/dev/mmwork/testl7,if=ide,index=0,boot=on,format=raw,serial
=WD-WMAM9TD73523,cache=writeback

Yeah, bug exists. only WD-W serial is seen inside VM.

Patch

--- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
+++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
@@ -2397,7 +2397,7 @@ 
     dinfo->on_write_error = on_write_error;
     dinfo->opts = opts;
     if (serial)
-        strncpy(dinfo->serial, serial, sizeof(serial));
+        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
     QTAILQ_INSERT_TAIL(&drives, dinfo, next);
     if (is_extboot) {
         extboot_drive = dinfo;