diff mbox

[U-Boot,2/7] arm: colibri-vf: Enable serial support

Message ID 1453448992-20178-3-git-send-email-bhuvanchandra.dv@toradex.com
State Superseded
Delegated to: Stefano Babic
Headers show

Commit Message

Bhuvanchandra DV Jan. 22, 2016, 7:49 a.m. UTC
---
 arch/arm/dts/vf-colibri.dtsi     | 10 ++++++++++
 configs/colibri_vf_dtb_defconfig |  1 +
 2 files changed, 11 insertions(+)

Comments

Bin Meng Jan. 22, 2016, 9:52 a.m. UTC | #1
Hi Bhuvanchandra,

On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV
<bhuvanchandra.dv@toradex.com> wrote:
> ---

Please always include a commit message.

>  arch/arm/dts/vf-colibri.dtsi     | 10 ++++++++++
>  configs/colibri_vf_dtb_defconfig |  1 +
>  2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/vf-colibri.dtsi b/arch/arm/dts/vf-colibri.dtsi
> index 7a8e9bee..0718486 100644
> --- a/arch/arm/dts/vf-colibri.dtsi
> +++ b/arch/arm/dts/vf-colibri.dtsi
> @@ -10,6 +10,12 @@
>   */
>  #include "vf.dtsi"
>
> +/ {
> +       chosen {
> +               stdout-path = &uart0;
> +       };
> +};
> +
>  &dspi1 {
>         status = "okay";
>         bus-num = <1>;
> @@ -19,3 +25,7 @@
>                 spi-max-frequency = <50000000>;
>         };
>  };
> +
> +&uart0 {
> +       status = "okay";
> +};
> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig

Why adding _dtb here? Can we update the existing defconfig files?

> index b1a843a..b204fb8 100644
> --- a/configs/colibri_vf_dtb_defconfig
> +++ b/configs/colibri_vf_dtb_defconfig
> @@ -11,4 +11,5 @@ CONFIG_OF_CONTROL=y
>  CONFIG_DM=y
>  CONFIG_NAND_VF610_NFC=y
>  CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
> +CONFIG_DM_SERIAL=y
>  CONFIG_FSL_LPUART=y
> --

Please try to insert new Kconfig options in a correct order. You can
get it via 'make savedefconfig'.

Regards,
Bin
Bhuvanchandra DV Jan. 22, 2016, 12:21 p.m. UTC | #2
Hi Bin,

On 01/22/2016 03:22 PM, Bin Meng wrote:
> Hi Bhuvanchandra,
>
> On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV
> <bhuvanchandra.dv@toradex.com> wrote:
>> ---
>
> Please always include a commit message.

Okay

>
>>   arch/arm/dts/vf-colibri.dtsi     | 10 ++++++++++
>>   configs/colibri_vf_dtb_defconfig |  1 +
>>   2 files changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/dts/vf-colibri.dtsi b/arch/arm/dts/vf-colibri.dtsi
>> index 7a8e9bee..0718486 100644
>> --- a/arch/arm/dts/vf-colibri.dtsi
>> +++ b/arch/arm/dts/vf-colibri.dtsi
>> @@ -10,6 +10,12 @@
>>    */
>>   #include "vf.dtsi"
>>
>> +/ {
>> +       chosen {
>> +               stdout-path = &uart0;
>> +       };
>> +};
>> +
>>   &dspi1 {
>>          status = "okay";
>>          bus-num = <1>;
>> @@ -19,3 +25,7 @@
>>                  spi-max-frequency = <50000000>;
>>          };
>>   };
>> +
>> +&uart0 {
>> +       status = "okay";
>> +};
>> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
>
> Why adding _dtb here? Can we update the existing defconfig files?
>
>> index b1a843a..b204fb8 100644
>> --- a/configs/colibri_vf_dtb_defconfig
>> +++ b/configs/colibri_vf_dtb_defconfig
>> @@ -11,4 +11,5 @@ CONFIG_OF_CONTROL=y
>>   CONFIG_DM=y
>>   CONFIG_NAND_VF610_NFC=y
>>   CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
>> +CONFIG_DM_SERIAL=y
>>   CONFIG_FSL_LPUART=y
>> --
>
> Please try to insert new Kconfig options in a correct order. You can
> get it via 'make savedefconfig'.

Will do it.

>
> Regards,
> Bin
>
diff mbox

Patch

diff --git a/arch/arm/dts/vf-colibri.dtsi b/arch/arm/dts/vf-colibri.dtsi
index 7a8e9bee..0718486 100644
--- a/arch/arm/dts/vf-colibri.dtsi
+++ b/arch/arm/dts/vf-colibri.dtsi
@@ -10,6 +10,12 @@ 
  */
 #include "vf.dtsi"
 
+/ {
+	chosen {
+		stdout-path = &uart0;
+	};
+};
+
 &dspi1 {
 	status = "okay";
 	bus-num = <1>;
@@ -19,3 +25,7 @@ 
 		spi-max-frequency = <50000000>;
 	};
 };
+
+&uart0 {
+	status = "okay";
+};
diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
index b1a843a..b204fb8 100644
--- a/configs/colibri_vf_dtb_defconfig
+++ b/configs/colibri_vf_dtb_defconfig
@@ -11,4 +11,5 @@  CONFIG_OF_CONTROL=y
 CONFIG_DM=y
 CONFIG_NAND_VF610_NFC=y
 CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
+CONFIG_DM_SERIAL=y
 CONFIG_FSL_LPUART=y