From patchwork Mon Jun 28 14:38:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Don't reset bs->is_temporary in bdrv_open_common Date: Mon, 28 Jun 2010 04:38:33 -0000 From: Ryan Harper X-Patchwork-Id: 57145 Message-Id: <20100628143833.GB1647@us.ibm.com> To: Michael Roth Cc: Kevin Wolf , qemu-devel@nongnu.org To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to call unlink() on temporary snapshots due to bs->is_temporary getting clobbered in bdrv_open_common() after being set in bdrv_open() which calls the former. We don't need to initialize bs->is_temporary in bdrv_open_common(). Signed-off-by: Ryan Harper --- block.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index e71a771..a55882e 100644 --- a/block.c +++ b/block.c @@ -393,7 +393,6 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, bs->file = NULL; bs->total_sectors = 0; - bs->is_temporary = 0; bs->encrypted = 0; bs->valid_key = 0; bs->open_flags = flags;