diff mbox

Detangle gcc/configure for Darwin

Message ID CAGWvnymOeQ1gN7HndamyfOGs=xztEEqud2588RcJLQPja_K_GA@mail.gmail.com
State New
Headers show

Commit Message

David Edelsohn Jan. 21, 2016, 2:50 p.m. UTC
A gcc/configure stanza to test for PowerPC mfcrf support became
tangled with Darwin test for .machine directive.  This patch detangles
and separates the two tests.

I don't have a Darwin system to test.

* configure.ac (gcc_cv_as_powerpc_mfcrf, gcc_cv_as_machine_directive): Detangle.

Okay?

Thanks, David

        .text

Comments

Mike Stump Jan. 21, 2016, 6:09 p.m. UTC | #1
On Jan 21, 2016, at 6:50 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> A gcc/configure stanza to test for PowerPC mfcrf support became
> tangled with Darwin test for .machine directive.  This patch detangles
> and separates the two tests.
> 
> I don't have a Darwin system to test.
> 
> * configure.ac (gcc_cv_as_powerpc_mfcrf, gcc_cv_as_machine_directive): Detangle.
> 
> Okay?

Ok.

Would have been slightly easier to back out the patch that went wrong, and review the re-application of that patch as it should have been originally.
diff mbox

Patch

Index: configure.ac
===================================================================
--- configure.ac        (revision 232675)
+++ configure.ac        (working copy)
@@ -4172,10 +4172,8 @@ 
     ;;

   powerpc*-*-*)
+
     case $target in
-      *-*-aix*) conftest_s='   .machine "pwr5"
-       .csect .text[[PR]]
-       mfcr 3,128';;
       *-*-darwin*)
        gcc_GAS_CHECK_FEATURE([.machine directive support],
          gcc_cv_as_machine_directive,,,
@@ -4185,7 +4183,14 @@ 
          echo you can get it from:
ftp://gcc.gnu.org/pub/gcc/infrastructure/cctools-528.5.dmg >&2
          test x$build = x$target && exit 1
        fi
-       conftest_s='    .text
+        ;;
+    esac
+
+    case $target in
+      *-*-aix*) conftest_s='   .machine "pwr5"
+       .csect .text[[PR]]
+       mfcr 3,128';;
+      *-*-darwin*) conftest_s='        .text
        mfcr r3,128';;
       *) conftest_s='  .machine power4