Patchwork [wwwdocs] Generated files and patches

login
register
mail settings
Submitter Gerald Pfeifer
Date June 27, 2010, 11:33 p.m.
Message ID <alpine.LSU.1.99.1006280132010.9343@acrux.dbai.tuwien.ac.at>
Download mbox | patch
Permalink /patch/57109/
State New
Headers show

Comments

Gerald Pfeifer - June 27, 2010, 11:33 p.m.
On Thu, 24 Jun 2010, Manuel López-Ibáñez wrote:
>> someone told me that generated files should be not included in patches.  It
>> would be nice if this is mentioned at
>>
>> http://gcc.gnu.org/contribute.html
>>
>> Who writes the ChangeLog for the generated files?
> I would say that the original submitter should just write:
> 
>  * configure.in: Regenerate.
> 
> even if the patch does not contain that part.

How about the following clarification to 
  http://gcc.gnu.org/contribute.html 
?  Sebastian, would that have helped?  Manuel, any other suggestions?

Gerald
Sebastian Huber - June 30, 2010, 12:38 p.m.
On 06/28/2010 01:33 AM, Gerald Pfeifer wrote:
[...]
> How about the following clarification to 
>   http://gcc.gnu.org/contribute.html 
> ?  Sebastian, would that have helped?  Manuel, any other suggestions?
[...]

Yes, this is good.
Gerald Pfeifer - July 10, 2010, 8:24 p.m.
On Wed, 30 Jun 2010, Sebastian Huber wrote:
>> How about the following clarification to 
>>   http://gcc.gnu.org/contribute.html 
>> ?  Sebastian, would that have helped?  Manuel, any other suggestions?
> Yes, this is good.

Thanks, Sebastian!  And sorry for missing your patch, which I only saw 
later on the last after I had responded to the direct mail.  If you have 
any further suggestions, or even patches, do not hesitate to send them our 
way!  (And be my guest copying me directly on anything related to our web 
pages.)

Gerald

Patch

Index: contribute.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/contribute.html,v
retrieving revision 1.74
diff -u -3 -p -r1.74 contribute.html
--- contribute.html	27 Jun 2010 23:26:43 -0000	1.74
+++ contribute.html	27 Jun 2010 23:31:59 -0000
@@ -231,7 +231,9 @@  gcc.gnu.org, please configure your svn t
 and generate patches using the &quot;<code>-up</code>&quot; or 
 &quot;<code>-cp</code>&quot; options.
 See <a href="http://gcc.gnu.org/wiki/SvnSetup">SVN setup instructions</a>
-for more details.
+for more details.<br />
+Do not include generated files as part of the patch, just mention
+them in the ChangeLog (e.g., "* configure: Regenerate."). 
 </dd>
 
 </dl>