| Message ID | 1453343029-14580-1-git-send-email-zhangshengju@cmss.chinamobile.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Thu, 21 Jan 2016 02:23:49 +0000 Zhang Shengju <zhangshengju@cmss.chinamobile.com> wrote: > the warning was: > iproute.c:301:12: warning: 'val' may be used uninitialized in this > function [-Wmaybe-uninitialized] > features &= ~RTAX_FEATURE_ECN; > ^ > iproute.c:575:10: note: 'val' was declared here > __u32 val; > ^ > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > --- > ip/iproute.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/iproute.c b/ip/iproute.c > index d5e3ebe..afe70e1 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -572,7 +572,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) > mxlock = *(unsigned*)RTA_DATA(mxrta[RTAX_LOCK]); > > for (i=2; i<= RTAX_MAX; i++) { > - __u32 val; > + __u32 val = 0U; > > if (mxrta[i] == NULL) > continue; Your compiler is doing bad dependency analysis. There is not really a bug here. It would still be best to initialize to keep broken compilers from causing warning.
diff --git a/ip/iproute.c b/ip/iproute.c index d5e3ebe..afe70e1 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -572,7 +572,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) mxlock = *(unsigned*)RTA_DATA(mxrta[RTAX_LOCK]); for (i=2; i<= RTAX_MAX; i++) { - __u32 val; + __u32 val = 0U; if (mxrta[i] == NULL) continue;
the warning was: iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] features &= ~RTAX_FEATURE_ECN; ^ iproute.c:575:10: note: 'val' was declared here __u32 val; ^ Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)