From patchwork Sun Jun 27 13:10:59 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Steven Bosscher <stevenb.gcc@gmail.com>
X-Patchwork-Id: 57095
Return-Path: 
 <gcc-patches-return-266520-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id 1CFFAB6EDF
	for <incoming@patchwork.ozlabs.org>;
	Sun, 27 Jun 2010 23:11:12 +1000 (EST)
Received: (qmail 7118 invoked by alias); 27 Jun 2010 13:11:09 -0000
Received: (qmail 7097 invoked by uid 22791); 27 Jun 2010 13:11:07 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL, BAYES_00,
	DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM
X-Spam-Check-By: sourceware.org
Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com)
	(209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with
	ESMTP; Sun, 27 Jun 2010 13:11:01 +0000
Received: by iwn9 with SMTP id 9so205080iwn.20 for <gcc-patches@gcc.gnu.org>;
	Sun, 27 Jun 2010 06:10:59 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.147.18 with SMTP id j18mr3560998ibv.12.1277644259532;
	Sun, 	27 Jun 2010 06:10:59 -0700 (PDT)
Received: by 10.231.207.83 with HTTP; Sun, 27 Jun 2010 06:10:59 -0700 (PDT)
In-Reply-To: <201006271445.15761.ebotcazou@adacore.com>
References: <201006271043.21089.ebotcazou@adacore.com>
	<AANLkTimHcqLj_Icsx3c_cITvcpaunuumrXNMdYB69xmZ@mail.gmail.com>
	<201006271445.15761.ebotcazou@adacore.com>
Date: Sun, 27 Jun 2010 15:10:59 +0200
Message-ID: <AANLkTin5fEghY_T3eap7tb6IpwpduxjnW0cGR8mkYHji@mail.gmail.com>
Subject: Re: [Ada] Fix bogus noreturn warning
From: Steven Bosscher <stevenb.gcc@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

On Sun, Jun 27, 2010 at 2:45 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> What is this necessary for? No front end should have to know
>> *anything* about tree-flow.h.
>
> block_may_fallthru is declared there.  See c-typeck.c, cp/decl.c and cp/tree.c
> for pre-existing counter-examples.

I'm not looking for counter-examples, just stating the way things
should be, not how things are (the Germans have a beautiful way of
expressing this: "Soll-Stand" vs. "Ist-Stand").  Your change moves us
further away from the way things should be. I hope you agree with
that?

Mind if I add a note, as below?

Ciao!
Steven

Index: ada/gcc-interface/trans.c
===================================================================
--- ada/gcc-interface/trans.c   (revision 161470)
+++ ada/gcc-interface/trans.c   (working copy)
@@ -33,7 +33,7 @@
 #include "output.h"
 #include "libfuncs.h"  /* For set_stack_check_libfunc.  */
 #include "tree-iterator.h"
-#include "tree-flow.h"
+#include "tree-flow.h" /* For block_may_fallthru.  */
 #include "gimple.h"

 #include "ada.h"