| Message ID | 1453277324-6180-1-git-send-email-ptikhomirov@virtuozzo.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote: > It seem to be non intentionaly changed to tx in > commit adc810900a70 ("ixgbe: Refactor busy poll socket code to > address > multiple issues") > > Lock is taken from ixgbe_low_latency_recv, and there under this > lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment > tx counter. > > Yield stats can be shown through ethtool: > ethtool -S enp129s0 | grep yield > > v2: follow commit citing style > > Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why are you re-sending this patch? I already have it queued up for testing in my tree. This just causes problems and extra work for me.
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h index 1d21745..7656d46 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h @@ -451,7 +451,7 @@ static inline bool ixgbe_qv_lock_poll(struct ixgbe_q_vector *q_vector) IXGBE_QV_STATE_POLL); #ifdef BP_EXTENDED_STATS if (rc != IXGBE_QV_STATE_IDLE) - q_vector->tx.ring->stats.yields++; + q_vector->rx.ring->stats.yields++; #endif return rc == IXGBE_QV_STATE_IDLE; }
It seem to be non intentionaly changed to tx in commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address multiple issues") Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment tx counter. Yield stats can be shown through ethtool: ethtool -S enp129s0 | grep yield v2: follow commit citing style Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)