| Message ID | 1453246074-1054-1-git-send-email-tanure@linux.com |
|---|---|
| State | Deferred, archived |
| Delegated to: | David Miller |
| Headers | show |
On 19/01/16 23:27, Lucas Tanure wrote: > Use eth_zero_addr to assign the zero address to the given address array > instead of memset when second argument is address of zero. > > Signed-off-by: Lucas Tanure <tanure@linux.com> > --- Acked-by: Bert Kenward <bkenward@solarflare.com> ... although net-next is still closed I think.
From: Bert Kenward <bkenward@solarflare.com> Date: Wed, 20 Jan 2016 09:44:30 +0000 > On 19/01/16 23:27, Lucas Tanure wrote: >> Use eth_zero_addr to assign the zero address to the given address array >> instead of memset when second argument is address of zero. >> >> Signed-off-by: Lucas Tanure <tanure@linux.com> >> --- > > Acked-by: Bert Kenward <bkenward@solarflare.com> > > ... although net-next is still closed I think. Correct.
Hello. On 1/20/2016 2:27 AM, Lucas Tanure wrote: > Use eth_zero_addr to assign the zero address to the given address array > instead of memset when second argument is address of zero. What address? memset() takes just 1 address. :-) > Signed-off-by: Lucas Tanure <tanure@linux.com> > --- > drivers/net/ethernet/sfc/ef10_sriov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c > index 3c17f27..10f60db 100644 > --- a/drivers/net/ethernet/sfc/ef10_sriov.c > +++ b/drivers/net/ethernet/sfc/ef10_sriov.c > @@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int vf_i, u8 *mac) > return 0; > > fail: > - memset(vf->mac, 0, ETH_ALEN); > + eth_zero_addr(vf->mac); > return rc; > } > MBR, Sergei
Hi, On Wed, Jan 20, 2016 at 9:44 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 1/20/2016 2:27 AM, Lucas Tanure wrote: > >> Use eth_zero_addr to assign the zero address to the given address array >> instead of memset when second argument is address of zero. > > > What address? memset() takes just 1 address. :-) I mean the vf->mac, a pointer to a six-byte array containing the Ethernet address. > >> Signed-off-by: Lucas Tanure <tanure@linux.com> >> --- >> drivers/net/ethernet/sfc/ef10_sriov.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c >> b/drivers/net/ethernet/sfc/ef10_sriov.c >> index 3c17f27..10f60db 100644 >> --- a/drivers/net/ethernet/sfc/ef10_sriov.c >> +++ b/drivers/net/ethernet/sfc/ef10_sriov.c >> @@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int >> vf_i, u8 *mac) >> return 0; >> >> fail: >> - memset(vf->mac, 0, ETH_ALEN); >> + eth_zero_addr(vf->mac); >> return rc; >> } >> > > MBR, Sergei > Thanks, Tanure
diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c index 3c17f27..10f60db 100644 --- a/drivers/net/ethernet/sfc/ef10_sriov.c +++ b/drivers/net/ethernet/sfc/ef10_sriov.c @@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int vf_i, u8 *mac) return 0; fail: - memset(vf->mac, 0, ETH_ALEN); + eth_zero_addr(vf->mac); return rc; }
Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. Signed-off-by: Lucas Tanure <tanure@linux.com> --- drivers/net/ethernet/sfc/ef10_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)