diff mbox

[1/1] package/triggerhappy: bump to latest commit to fix runtime issue

Message ID 1453197113-27321-1-git-send-email-joerg.krause@embedded.rocks
State Accepted
Commit cc9304aa7220d9b3657572940b1e61504f920e24
Headers show

Commit Message

Jörg Krause Jan. 19, 2016, 9:51 a.m. UTC
Bump to latest commit to fix runtime issue with the Linux Kernel headers 4.4:
  Starting thd: Unable to parse trigger line: [..]

With version 4.4 of the Linux Kernel the input event codes are not defined in
'linux/input.h' anymore, but in a seperate header file
'linux/input-event-codes.h' leaving triggerhappys evtable_*.h header files
empty with no event codes defined.

This issue is fixed upstream by commit 7e5abc69f215678e93a6b999524981c8b40bdcd9
which also makes overwriting of the 'LINUX_INPUT_H' definition obsolet.

Tested with an internal Buildroot toolchain with Linux Kernel headers 4.4 and
an external Linaro ARM 2015.08 toolchain with Linux Kernel headers 4.0.

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
 package/triggerhappy/triggerhappy.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Peter Korsgaard Jan. 19, 2016, 9:54 p.m. UTC | #1
>>>>> "Jörg" == Jörg Krause <joerg.krause@embedded.rocks> writes:

 > Bump to latest commit to fix runtime issue with the Linux Kernel headers 4.4:
 >   Starting thd: Unable to parse trigger line: [..]

 > With version 4.4 of the Linux Kernel the input event codes are not defined in
 > 'linux/input.h' anymore, but in a seperate header file
 > 'linux/input-event-codes.h' leaving triggerhappys evtable_*.h header files
 > empty with no event codes defined.

 > This issue is fixed upstream by commit 7e5abc69f215678e93a6b999524981c8b40bdcd9
 > which also makes overwriting of the 'LINUX_INPUT_H' definition obsolet.

 > Tested with an internal Buildroot toolchain with Linux Kernel headers 4.4 and
 > an external Linaro ARM 2015.08 toolchain with Linux Kernel headers 4.0.

 > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>

Committed after adding a .hash file, thanks.
diff mbox

Patch

diff --git a/package/triggerhappy/triggerhappy.mk b/package/triggerhappy/triggerhappy.mk
index 3a68e50..5a29ca7 100644
--- a/package/triggerhappy/triggerhappy.mk
+++ b/package/triggerhappy/triggerhappy.mk
@@ -4,15 +4,13 @@ 
 #
 ################################################################################
 
-TRIGGERHAPPY_VERSION = aac9f353a28c0f414b27ac54bbbb2292c152eedc
+TRIGGERHAPPY_VERSION = 7e5abc69f215678e93a6b999524981c8b40bdcd9
 TRIGGERHAPPY_SITE = $(call github,wertarbyte,triggerhappy,$(TRIGGERHAPPY_VERSION))
 TRIGGERHAPPY_LICENSE = GPLv3+
 TRIGGERHAPPY_LICENSE_FILES = COPYING
 
 define TRIGGERHAPPY_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) \
-		LINUX_INPUT_H=$(STAGING_DIR)/usr/include/linux/input.h \
-		-C $(@D) thd th-cmd
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) thd th-cmd
 endef
 
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)